Skip to content

release/20.x: [llvm-objcopy][ReleaseNotes] Fix prints wrong path when dump-section output path doesn't exist #125345 #126607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025
Merged

release/20.x: [llvm-objcopy][ReleaseNotes] Fix prints wrong path when dump-section output path doesn't exist #125345 #126607

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8886b33
release/20.x: [llvm-objcopy][ReleaseNotes] Fix prints wrong path when…
AmrDeveloper Feb 10, 2025
6f5ced0
Add quote around option name
AmrDeveloper Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions llvm/docs/ReleaseNotes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,8 @@ Changes to the LLVM tools
`--localize-symbol`, `--localize-symbols`,
`--skip-symbol`, `--skip-symbols`.

* llvm-objcopy now prints the correct file path in the error message when the output file specified by --dump-section cannot be opened.
Copy link
Member

@MaskRay MaskRay Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double quotes around the option name.

Copy link
Member Author

@AmrDeveloper AmrDeveloper Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it --dump-section to be similar to all other options in the same file


Changes to LLDB
---------------------------------

Expand Down