Skip to content

Conversation

@mayanez
Copy link
Contributor

@mayanez mayanez commented Feb 11, 2025

@mayanez mayanez added cmake Build system in general and CMake in particular platform:windows labels Feb 11, 2025
@llvmbot llvmbot added the lld label Feb 11, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 11, 2025

@llvm/pr-subscribers-lld

@llvm/pr-subscribers-platform-windows

Author: Miguel A. Arroyo (mayanez)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/126680.diff

1 Files Affected:

  • (modified) lld/cmake/modules/AddLLD.cmake (+4)
diff --git a/lld/cmake/modules/AddLLD.cmake b/lld/cmake/modules/AddLLD.cmake
index 9f2684b6f933eca..22e7a7c0f6faa64 100644
--- a/lld/cmake/modules/AddLLD.cmake
+++ b/lld/cmake/modules/AddLLD.cmake
@@ -57,6 +57,10 @@ macro(add_lld_tool name)
         RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}"
         COMPONENT ${name})
 
+      if (LLVM_ENABLE_PDB)
+        install(FILES $<TARGET_PDB_FILE:${name}> DESTINATION "${CMAKE_INSTALL_BINDIR}" COMPONENT ${name} OPTIONAL)
+      endif()
+
       if(NOT CMAKE_CONFIGURATION_TYPES)
         add_llvm_install_targets(install-${name}
           DEPENDS ${name}

@mayanez mayanez requested review from aganea and compnerd February 12, 2025 03:42
@mayanez mayanez force-pushed the build/cmakepdb-lld branch from 1b82889 to 00fb4c8 Compare May 23, 2025 19:04
@mayanez mayanez merged commit e100f54 into llvm:main May 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmake Build system in general and CMake in particular lld platform:windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants