Skip to content

[LoopIdiom] Select llvm.experimental.memset.pattern intrinsic rather than memset_pattern16 libcall #126736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jul 9, 2025
Merged

[LoopIdiom] Select llvm.experimental.memset.pattern intrinsic rather than memset_pattern16 libcall #126736

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
a052059
[LoopIdiom] Select llvm.experimental.memset.pattern intrinsic rather …
asb Feb 11, 2025
6409a4b
Merge remote-tracking branch 'origin/main' into 2025q1-loopidiom-reco…
asb Feb 24, 2025
59ecf00
Merge remote-tracking branch 'origin/main' into 2025q1-loopidiom-reco…
asb Feb 28, 2025
809320f
Fix bit/bytes confusion in setting alignment
asb Feb 28, 2025
b561986
Merge remote-tracking branch 'origin/main' into 2025q1-loopidiom-reco…
asb Mar 5, 2025
808e5c2
Excise unneeded logic for creating a globalvariable (which was still …
asb Mar 5, 2025
756d7a4
Merge remote-tracking branch 'origin/main' into 2025q1-loopidiom-reco…
asb Mar 12, 2025
763b40a
Remove unnecessary initialisation of std::optional
asb Mar 12, 2025
48a9ed8
auto *CI and remove comment that's made redundant
asb Mar 12, 2025
71e0307
Merge remote-tracking branch 'origin/main' into 2025q1-loopidiom-reco…
asb Mar 28, 2025
07c8df2
Set alignment for dest ptr of emitted memset.pattern
asb Mar 28, 2025
3e77fd8
Tweak description of ForceMemsetPatternIntrinsic
asb Mar 28, 2025
e693285
Merge remote-tracking branch 'origin/main' into 2025q1-loopidiom-reco…
asb Apr 17, 2025
77ba4b4
Drop outdated comment
asb Apr 17, 2025
fbed3bc
Tweak comment as per Craig's suggestion
asb Apr 17, 2025
07af8f7
Fix incorrectly resolved merge conflict
asb Apr 17, 2025
b70871c
Merge remote-tracking branch 'origin/main' into 2025q1-loopidiom-reco…
asb Apr 23, 2025
23dcffe
Merge remote-tracking branch 'origin/main' into 2025q1-loopidiom-reco…
asb Apr 23, 2025
13ae5b8
Merge remote-tracking branch 'origin/main' into 2025q1-loopidiom-reco…
asb Apr 30, 2025
e6bb52c
Merge remote-tracking branch 'origin/main' into 2025q1-loopidiom-reco…
asb Jun 11, 2025
c15584d
Merge remote-tracking branch 'origin/main' into 2025q1-loopidiom-reco…
asb Jun 12, 2025
c178f9f
Make use of the fact memset.pattern allows any sized type as arg
asb Jun 18, 2025
7a5495d
[PreISelIntrinsicLowering] Reuse previously generated GlobalVariable …
asb Jun 18, 2025
d8b4ae1
Merge remote-tracking branch 'origin/main' into 2025q1-loopidiom-reco…
asb Jun 25, 2025
43a05fd
Merge remote-tracking branch 'origin/main' into 2025q1-loopidiom-reco…
asb Jul 9, 2025
c6714f2
Check type directly in getMemsetPatternValue as suggested by nikic
asb Jul 9, 2025
cdd5029
Fix comment at top of getMemSetPatternValue
asb Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1154,7 +1154,7 @@ bool LoopIdiomRecognize::processLoopStridedStore(
PatternValue, ".memset_pattern");
GV->setUnnamedAddr(
GlobalValue::UnnamedAddr::Global); // Ok to merge these.
GV->setAlignment(Align(PatternArgTy->getPrimitiveSizeInBits()));
GV->setAlignment(Align(PatternArgTy->getPrimitiveSizeInBits() / 8));
PatternArg = Builder.CreateLoad(PatternArgTy, GV);
}
assert(PatternArg);
Expand Down
2 changes: 1 addition & 1 deletion llvm/test/Transforms/LoopIdiom/basic.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ target triple = "x86_64-apple-darwin10.0.0"
;.
; CHECK: @G = global i32 5
; CHECK: @g_50 = global [7 x i32] [i32 0, i32 0, i32 0, i32 0, i32 1, i32 0, i32 0], align 16
; CHECK: @.memset_pattern = private unnamed_addr constant ptr @G, align 64
; CHECK: @.memset_pattern = private unnamed_addr constant ptr @G, align 8
;.
define void @test1(ptr %Base, i64 %Size) nounwind ssp {
; CHECK-LABEL: @test1(
Expand Down
Loading