[lldb-dap] Upgrade @types/node to fix TS2386 in node/module.d.ts #126994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009
JDevlieghere
requested review from
ashgti,
vogelsgesang and
walter-erquinigo
Member
|
@llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) ChangesUpgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: [1] microsoft/TypeScript#59259 (comment) Full diff: https://github.com/llvm/llvm-project/pull/126994.diff 2 Files Affected:
diff --git a/lldb/tools/lldb-dap/package-lock.json b/lldb/tools/lldb-dap/package-lock.json
index 4c18474241421..ab5c7dc33a8e5 100644
--- a/lldb/tools/lldb-dap/package-lock.json
+++ b/lldb/tools/lldb-dap/package-lock.json
@@ -1,15 +1,15 @@
{
"name": "lldb-dap",
- "version": "0.2.9",
+ "version": "0.2.10",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "lldb-dap",
- "version": "0.2.9",
+ "version": "0.2.10",
"license": "Apache 2.0 License with LLVM exceptions",
"devDependencies": {
- "@types/node": "^18.11.18",
+ "@types/node": "^18.19.41",
"@types/vscode": "1.75.0",
"@vscode/vsce": "^3.2.2",
"prettier": "^3.4.2",
@@ -389,10 +389,11 @@
}
},
"node_modules/@types/node": {
- "version": "18.19.6",
- "resolved": "https://registry.npmjs.org/@types/node/-/node-18.19.6.tgz",
- "integrity": "sha512-X36s5CXMrrJOs2lQCdDF68apW4Rfx9ixYMawlepwmE4Anezv/AV2LSpKD1Ub8DAc+urp5bk0BGZ6NtmBitfnsg==",
+ "version": "18.19.75",
+ "resolved": "https://registry.npmjs.org/@types/node/-/node-18.19.75.tgz",
+ "integrity": "sha512-UIksWtThob6ZVSyxcOqCLOUNg/dyO1Qvx4McgeuhrEtHTLFTf7BBhEazaE4K806FGTPtzd/2sE90qn4fVr7cyw==",
"dev": true,
+ "license": "MIT",
"dependencies": {
"undici-types": "~5.26.4"
}
diff --git a/lldb/tools/lldb-dap/package.json b/lldb/tools/lldb-dap/package.json
index 12d143babfd73..31d808eda4c35 100644
--- a/lldb/tools/lldb-dap/package.json
+++ b/lldb/tools/lldb-dap/package.json
@@ -27,7 +27,7 @@
"Debuggers"
],
"devDependencies": {
- "@types/node": "^18.11.18",
+ "@types/node": "^18.19.41",
"@types/vscode": "1.75.0",
"@vscode/vsce": "^3.2.2",
"prettier-plugin-curly": "^0.3.1",
|
ashgti
approved these changes
Feb 13, 2025
flovent
pushed a commit
to flovent/llvm-project
that referenced
this pull request
Feb 13, 2025
…m#126994) Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 14, 2025
…m#126994) Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Feb 24, 2025
…m#126994) Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009
SquallATF
pushed a commit
to SquallATF/llvm-project
that referenced
this pull request
Jun 13, 2025
…m#126994) Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009
SquallATF
pushed a commit
to SquallATF/llvm-project
that referenced
this pull request
Jul 14, 2025
…m#126994) Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail:
[1] microsoft/TypeScript#59259 (comment)
[2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009