[mlir][spirv] Update example of spirv.Constant(NFC)
#127030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually the `spirv.Constant dense<[2, 3]> : vector<2xf32>` will cause a error:
```
error: unexpected decimal integer literal for a floating point value
%cst = spirv.Constant dense<[2, 3]> : vector<2xf32>
^
```
The value should be explicite float.
Member
|
@llvm/pr-subscribers-mlir-spirv @llvm/pr-subscribers-mlir Author: Longsheng Mou (CoTinker) ChangesActually the The value should be an explicit float. Full diff: https://github.com/llvm/llvm-project/pull/127030.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td
index fbf750d643031..c5a85f881b35e 100644
--- a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td
+++ b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td
@@ -101,7 +101,7 @@ def SPIRV_ConstantOp : SPIRV_Op<"Constant",
```mlir
%0 = spirv.Constant true
- %1 = spirv.Constant dense<[2, 3]> : vector<2xf32>
+ %1 = spirv.Constant dense<[2.0, 3.0]> : vector<2xf32>
%2 = spirv.Constant [dense<3.0> : vector<2xf32>] : !spirv.array<1xvector<2xf32>>
```
|
Contributor
Author
|
Thanks for your review. |
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 14, 2025
Actually the `spirv.Constant dense<[2, 3]> : vector<2xf32>` will cause a
error:
```
error: unexpected decimal integer literal for a floating point value
%cst = spirv.Constant dense<[2, 3]> : vector<2xf32>
^
```
The value should be an explicit float.
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Feb 24, 2025
Actually the `spirv.Constant dense<[2, 3]> : vector<2xf32>` will cause a
error:
```
error: unexpected decimal integer literal for a floating point value
%cst = spirv.Constant dense<[2, 3]> : vector<2xf32>
^
```
The value should be an explicit float.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually the
spirv.Constant dense<[2, 3]> : vector<2xf32>will cause a error:The value should be an explicit float.