Skip to content

[IR][Instructions] Add CallBase::getCalledFunctionName helper #127038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[IR][Instructions] Add CallBase::getCalledFunctionName helper #127038

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
065431f
Add CallBase::getCalledFunctionName
tsymalla Feb 13, 2025
5d90a01
Some refactorings to make use of the new helper.
tsymalla Feb 20, 2025
793cde7
Use `getCalledFunctionName()` throughout the codebase.
tsymalla Feb 21, 2025
2f05b4e
Fix invalid whitespace character
tsymalla Feb 25, 2025
bbc216f
clang-format
tsymalla Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions llvm/include/llvm/IR/InstrTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1345,6 +1345,16 @@ class CallBase : public Instruction {
return nullptr;
}

/// Shortcut to retrieving the name of the called function.
/// Returns std::nullopt, if the function cannot be found.
std::optional<StringRef> getCalledFunctionName() const {
Function *F = getCalledFunction();
if (F)
return F->getName();

return std::nullopt;
Copy link
Contributor

@nikic nikic Feb 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use an empty StringRef as the sentinel instead?

Copy link
Contributor Author

@tsymalla tsymalla Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, yes, but I think std::optional is a better fit, since using operator* on the return value would fail if no value is present.

Copy link
Contributor

@arsenm arsenm Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which is the kind of failure you are trying to avoid needing to worry about?

}

/// Return true if the callsite is an indirect call.
bool isIndirectCall() const;

Expand Down