Skip to content

[CI] Do Not Consider a Job Failed if Steps Were Skipped #127279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 15, 2025
Merged

[CI] Do Not Consider a Job Failed if Steps Were Skipped #127279

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ae5cccd
[𝘀𝗽𝗿] changes to main this commit is based on
boomanaiden154 Feb 14, 2025
fb5ceb7
[𝘀𝗽𝗿] initial version
boomanaiden154 Feb 14, 2025
d65b8ff
[𝘀𝗽𝗿] changes introduced through rebase
boomanaiden154 Feb 15, 2025
f9524c0
rebase
boomanaiden154 Feb 15, 2025
2a8ec87
[𝘀𝗽𝗿] changes introduced through rebase
boomanaiden154 Feb 15, 2025
5fadb09
rebase
boomanaiden154 Feb 15, 2025
4e60b4b
[𝘀𝗽𝗿] changes introduced through rebase
boomanaiden154 Feb 15, 2025
63817db
rebase
boomanaiden154 Feb 15, 2025
21a858c
[𝘀𝗽𝗿] changes introduced through rebase
boomanaiden154 Feb 15, 2025
886a48d
rebase
boomanaiden154 Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/metrics/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ def get_per_workflow_metrics(
# longer in a testing state and we can directly assert the workflow
# result.
for step in workflow_job.steps:
if step.conclusion != "success":
if step.conclusion != "success" and step.conclusion != "skipped":
job_result = 0
break

Expand Down
Loading