[compiler-rt][asan] Re-enable ManyThreadsTest on AArch64 #127795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabled in 2ab51bf, doesn't hang for me on AArch64 (Graviton 3, tested 1000 iterations). May still be an issue, but hard to know unless we enable it again to find out. n.b. test was also disabled on PowerPC in 467afc5 for same reason and it has also been observed on x86: https://lists.llvm.org/pipermail/llvm-dev/2016-January/094607.html Fixes: llvm#24763
llvmbot
added
compiler-rt
compiler-rt:asan
Member
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Cullen Rhodes (c-rhodes) ChangesDisabled in 2ab51bf, doesn't hang for me on AArch64 (Graviton 3, tested 1000 iterations). May still be an issue, but hard to know unless we enable it again to find out. n.b. test was also disabled on PowerPC in Fixes: #24763 Full diff: https://github.com/llvm/llvm-project/pull/127795.diff 1 Files Affected:
diff --git a/compiler-rt/lib/asan/tests/asan_test.cpp b/compiler-rt/lib/asan/tests/asan_test.cpp
index 56377bde1c8de..0d98b1498a821 100644
--- a/compiler-rt/lib/asan/tests/asan_test.cpp
+++ b/compiler-rt/lib/asan/tests/asan_test.cpp
@@ -369,8 +369,7 @@ void *ManyThreadsWorker(void *a) {
return 0;
}
-#if !defined(__aarch64__) && !defined(__powerpc64__)
-// FIXME: Infinite loop in AArch64 (PR24389).
+#if !defined(__powerpc64__)
// FIXME: Also occasional hang on powerpc. Maybe same problem as on AArch64?
TEST(AddressSanitizer, ManyThreadsTest) {
const size_t kNumThreads =
|
Collaborator
|
cc @rengolin |
vitalybuka
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled in 2ab51bf, doesn't hang for me on AArch64 (Graviton 3, tested 1000 iterations). May still be an issue, but hard to know unless we enable it again to find out.
n.b. test was also disabled on PowerPC in
467afc5 for same reason and it has also been observed on x86:
https://lists.llvm.org/pipermail/llvm-dev/2016-January/094607.html
Fixes: #24763