[CodeGen][NFC] Move test builtin_signbit.cpp to CodeGen #127814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it is one of the three "misplaced" test files that appeared under `/clang/test/Analysis` but were unrelated to the clang static analyzer. For background see the following discourse thread: https://discourse.llvm.org/t/taking-ownership-of-clang-test-analysis/84689/2 I placed this file in `clang/test/CodeGen` because as far as I see it tests the code generated from `__builtin_signbit` (and there are many other `builtin_*` test files in that directory); but I'm not familiar with that area, so I'm not certain that it's the best place.
Member
|
@llvm/pr-subscribers-clang Author: Donát Nagy (NagyDonat) ChangesBecause it is one of the three "misplaced" test files that appeared under I placed this file in Full diff: https://github.com/llvm/llvm-project/pull/127814.diff 1 Files Affected:
diff --git a/clang/test/Analysis/builtin_signbit.cpp b/clang/test/CodeGen/builtin_signbit.cpp
similarity index 100%
rename from clang/test/Analysis/builtin_signbit.cpp
rename to clang/test/CodeGen/builtin_signbit.cpp
|
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/13334 Here is the relevant piece of the build log for the reference |
Contributor
Author
|
The CI failure is in a completely unrelated test file; I'm pretty confident that it's unrelated to my commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it is one of the three "misplaced" test files that appeared under
/clang/test/Analysisbut were unrelated to the clang static analyzer. For background see the following discourse thread: https://discourse.llvm.org/t/taking-ownership-of-clang-test-analysis/84689/2I placed this file in
clang/test/CodeGenbecause as far as I see it tests the code generated from__builtin_signbit(and there are many otherbuiltin_*test files in that directory); but I'm not familiar with that area, so I'm not certain that it's the best place.