[Github][CI] Enable New Premerge on PRs #127894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch gets rid of the file restriction for running the new premerge Github workflow on PRs. This will cause the jobs to be run on all the PRs. Currently the jobs will succeed regardless of build/test failure results. This will let us test the new infra hopefully without too much disruption before eventually letting jobs fail when builds/tests fail and deprecating the existing premerge system. This is part of the launch plan as outlined in https://discourse.llvm.org/t/googles-plan-for-the-llvm-presubmit-infrastructure/78940.
Member
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThis patch gets rid of the file restriction for running the new premerge Github workflow on PRs. This will cause the jobs to be run on all the PRs. Currently the jobs will succeed regardless of build/test failure results. This will let us test the new infra hopefully without too much disruption before eventually letting jobs fail when builds/tests fail and deprecating the existing premerge system. This is part of the launch plan as outlined in Full diff: https://github.com/llvm/llvm-project/pull/127894.diff 1 Files Affected:
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index 49753c0746cbe..2d366028c2337 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -14,8 +14,6 @@ on:
# do this is that it allows us to take advantage of concurrency groups
# to cancel in progress CI jobs whenever the PR is closed.
- closed
- paths:
- - .github/workflows/premerge.yaml
push:
branches:
- 'main'
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch gets rid of the file restriction for running the new premerge Github workflow on PRs. This will cause the jobs to be run on all the PRs. Currently the jobs will succeed regardless of build/test failure results. This will let us test the new infra hopefully without too much disruption before eventually letting jobs fail when builds/tests fail and deprecating the existing premerge system.
This is part of the launch plan as outlined in
https://discourse.llvm.org/t/googles-plan-for-the-llvm-presubmit-infrastructure/78940.