[libc++] Shuffle the order of pre-commit CI jobs a bit #128008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've recently noticed that our CI is bottlenecked around platforms on which we don't have a lot of capacity like macOS (mostly) and Windows. To try to alleviate that, this patch moves the macOS builds and the Windows builds further down the pipeline so that they will get triggered less often (if an earlier job fails).
llvmbot
added
libc++
Member
|
@llvm/pr-subscribers-libcxx @llvm/pr-subscribers-github-workflow Author: Louis Dionne (ldionne) ChangesI've recently noticed that our CI is bottlenecked around platforms on which we don't have a lot of capacity like macOS (mostly) and Windows. To try to alleviate that, this patch moves the macOS builds and the Windows builds further down the pipeline so that they will get triggered less often (if an earlier job fails). Full diff: https://github.com/llvm/llvm-project/pull/128008.diff 1 Files Affected:
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index d0193a4ec2faa..93e673ca513a4 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -124,7 +124,7 @@ jobs:
**/crash_diagnostics/*
stage3:
if: github.repository_owner == 'llvm'
- needs: [ stage1, stage2 ]
+ needs: [ stage2 ]
continue-on-error: false
strategy:
fail-fast: false
@@ -188,7 +188,7 @@ jobs:
**/crash_diagnostics/*
macos:
- needs: [ stage1 ]
+ needs: [ stage3 ]
strategy:
fail-fast: false
matrix:
@@ -232,7 +232,7 @@ jobs:
windows:
runs-on: windows-2022
- needs: [ stage1 ]
+ needs: [ stage2 ]
strategy:
fail-fast: false
matrix:
|
Contributor
|
FWIW I find the title of the patch a bit misleading. This makes the pipeline even longer, which isn't at all obvious and I'm really not a huge fan of making it even longer. Is this intended to be permanent? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently noticed that our CI is bottlenecked around platforms on which we don't have a lot of capacity like macOS (mostly) and Windows. To try to alleviate that, this patch moves the macOS builds and the Windows builds further down the pipeline so that they will get triggered less often (if an earlier job fails).