[mlir][tosa] Fix ability to expand ranks with dynamic shape support #128037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-mlir-tosa @llvm/pr-subscribers-mlir Author: Jerry-Ge (Jerry-Ge) ChangesFix ability to expand ranks with dynamic shape support Full diff: https://github.com/llvm/llvm-project/pull/128037.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/Tosa/Utils/ConversionUtils.cpp b/mlir/lib/Dialect/Tosa/Utils/ConversionUtils.cpp
index d1a8732dac212..9ade05c8f095b 100644
--- a/mlir/lib/Dialect/Tosa/Utils/ConversionUtils.cpp
+++ b/mlir/lib/Dialect/Tosa/Utils/ConversionUtils.cpp
@@ -88,9 +88,9 @@ computeReshapeOutput(ArrayRef<int64_t> higherRankShape,
higherRankDim = higherRankShape[i];
lowerRankDim = lowerRankShape[j];
- if (lowerRankDim == 1 && higherRankDim > 1)
+ if (lowerRankDim == 1 && higherRankDim != 1)
reshapeOutputShape[i] = 1;
- else if ((lowerRankDim > 1 && higherRankDim == 1) ||
+ else if ((lowerRankDim != 1 && higherRankDim == 1) ||
(lowerRankDim == higherRankDim))
reshapeOutputShape[i] = lowerRankDim;
else if (higherRankDim != lowerRankDim)
|
lhutton1
reviewed
Feb 24, 2025
Contributor
lhutton1
left a comment
lhutton1
left a comment
There was a problem hiding this comment.
Is it possible to test this change at all?
Member
Author
good question, i don't have a clear answer. CC the original author: @sjarus |
GeorgeARM
reviewed
Feb 24, 2025
Jerry-Ge
force-pushed
the
expand_ranks
branch
2 times, most recently
from
9f7d82f to
16462f4
Compare
GeorgeARM
reviewed
Feb 25, 2025
- The use of != 1 accommodates the use of kDynamicDim - Simplified the for loop to iterate only on lowerRank and access the higherRank dim by using the rankDiff Signed-off-by: Suraj Sudhir <[email protected]> Change-Id: I0f223f335667b2e32c43d4370f0a4b11b0617694
Jerry-Ge
force-pushed
the
expand_ranks
branch
from
16462f4 to
72b7eaf
Compare
GeorgeARM
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.