Skip to content

[clang][NFC] Update isAuxBuiltinID comment #128038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025
Merged

[clang][NFC] Update isAuxBuiltinID comment #128038

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e866ecf
[clang][NFC] Update isAuxBuiltinID comment
sarnex Feb 20, 2025
e7b0641
address feedback
sarnex Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion clang/include/clang/Basic/Builtins.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,9 @@ class Context {

unsigned getRequiredVectorWidth(unsigned ID) const;

/// Return true if builtin ID belongs to AuxTarget.
/// Return true if builtin ID belongs to only the AuxTarget.
Copy link
Collaborator

@erichkeane erichkeane Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, "Return true if the builtin ID belongs exclusively to the AuxTarget, and false if it belongs to both primary and aux target, or neither."

WDYT?

Copy link
Member Author

@sarnex sarnex Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, applied this in latest commit.

/// Return false if builtin ID belongs to both the primary
/// and auxiliary target.
bool isAuxBuiltinID(unsigned ID) const {
return ID >= (Builtin::FirstTSBuiltin + NumTargetBuiltins);
}
Expand Down