Skip to content

Conversation

@dklimkin
Copy link
Member

The file can't be parsed on it's own, except when included in the .cc. Should be .h.inc to avoid build errors.

@llvmbot llvmbot added mlir mlir:tosa bazel "Peripheral" support tier build system: utils/bazel labels Feb 21, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 21, 2025

@llvm/pr-subscribers-mlir-tosa

Author: Danial Klimkin (dklimkin)

Changes

The file can't be parsed on it's own, except when included in the .cc. Should be .h.inc to avoid build errors.


Full diff: https://github.com/llvm/llvm-project/pull/128153.diff

3 Files Affected:

  • (renamed) mlir/include/mlir/Dialect/Tosa/IR/TosaComplianceData.h.inc ()
  • (modified) mlir/lib/Dialect/Tosa/Transforms/TosaProfileCompliance.cpp (+1-1)
  • (modified) utils/bazel/llvm-project-overlay/mlir/BUILD.bazel (+3-1)
diff --git a/mlir/include/mlir/Dialect/Tosa/IR/TosaComplianceData.h b/mlir/include/mlir/Dialect/Tosa/IR/TosaComplianceData.h.inc
similarity index 100%
rename from mlir/include/mlir/Dialect/Tosa/IR/TosaComplianceData.h
rename to mlir/include/mlir/Dialect/Tosa/IR/TosaComplianceData.h.inc
diff --git a/mlir/lib/Dialect/Tosa/Transforms/TosaProfileCompliance.cpp b/mlir/lib/Dialect/Tosa/Transforms/TosaProfileCompliance.cpp
index 26960f0be6637..98d7c1dabd100 100644
--- a/mlir/lib/Dialect/Tosa/Transforms/TosaProfileCompliance.cpp
+++ b/mlir/lib/Dialect/Tosa/Transforms/TosaProfileCompliance.cpp
@@ -27,7 +27,7 @@ TosaProfileCompliance::TosaProfileCompliance() {
 
 // The profile-based compliance content below is auto-generated by a script
 // in https://git.mlplatform.org/tosa/specification.git
-#include "mlir/Dialect/Tosa/IR/TosaComplianceData.h"
+#include "mlir/Dialect/Tosa/IR/TosaComplianceData.h.inc"
   // End of auto-generated metadata
 }
 
diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
index e4b1cffcea782..8db94279a7cbc 100644
--- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -12356,7 +12356,9 @@ cc_library(
         "lib/Dialect/Tosa/IR/*.cpp",
         "lib/Dialect/Tosa/Utils/*.cpp",
         "lib/Dialect/Tosa/Transforms/*.cpp",
-    ]),
+    ]) + [
+        "include/mlir/Dialect/Tosa/IR/TosaComplianceData.h.inc",
+    ],
     hdrs = glob([
         "include/mlir/Dialect/Tosa/IR/*.h",
         "include/mlir/Dialect/Tosa/Utils/*.h",

@llvmbot
Copy link
Member

llvmbot commented Feb 21, 2025

@llvm/pr-subscribers-mlir

Author: Danial Klimkin (dklimkin)

Changes

The file can't be parsed on it's own, except when included in the .cc. Should be .h.inc to avoid build errors.


Full diff: https://github.com/llvm/llvm-project/pull/128153.diff

3 Files Affected:

  • (renamed) mlir/include/mlir/Dialect/Tosa/IR/TosaComplianceData.h.inc ()
  • (modified) mlir/lib/Dialect/Tosa/Transforms/TosaProfileCompliance.cpp (+1-1)
  • (modified) utils/bazel/llvm-project-overlay/mlir/BUILD.bazel (+3-1)
diff --git a/mlir/include/mlir/Dialect/Tosa/IR/TosaComplianceData.h b/mlir/include/mlir/Dialect/Tosa/IR/TosaComplianceData.h.inc
similarity index 100%
rename from mlir/include/mlir/Dialect/Tosa/IR/TosaComplianceData.h
rename to mlir/include/mlir/Dialect/Tosa/IR/TosaComplianceData.h.inc
diff --git a/mlir/lib/Dialect/Tosa/Transforms/TosaProfileCompliance.cpp b/mlir/lib/Dialect/Tosa/Transforms/TosaProfileCompliance.cpp
index 26960f0be6637..98d7c1dabd100 100644
--- a/mlir/lib/Dialect/Tosa/Transforms/TosaProfileCompliance.cpp
+++ b/mlir/lib/Dialect/Tosa/Transforms/TosaProfileCompliance.cpp
@@ -27,7 +27,7 @@ TosaProfileCompliance::TosaProfileCompliance() {
 
 // The profile-based compliance content below is auto-generated by a script
 // in https://git.mlplatform.org/tosa/specification.git
-#include "mlir/Dialect/Tosa/IR/TosaComplianceData.h"
+#include "mlir/Dialect/Tosa/IR/TosaComplianceData.h.inc"
   // End of auto-generated metadata
 }
 
diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
index e4b1cffcea782..8db94279a7cbc 100644
--- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -12356,7 +12356,9 @@ cc_library(
         "lib/Dialect/Tosa/IR/*.cpp",
         "lib/Dialect/Tosa/Utils/*.cpp",
         "lib/Dialect/Tosa/Transforms/*.cpp",
-    ]),
+    ]) + [
+        "include/mlir/Dialect/Tosa/IR/TosaComplianceData.h.inc",
+    ],
     hdrs = glob([
         "include/mlir/Dialect/Tosa/IR/*.h",
         "include/mlir/Dialect/Tosa/Utils/*.h",

@dklimkin dklimkin merged commit d6858dd into llvm:main Feb 21, 2025
10 of 14 checks passed
@dklimkin dklimkin deleted the hinc branch February 21, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bazel "Peripheral" support tier build system: utils/bazel mlir:tosa mlir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants