[Dexter] Remove clang-opt-bisect analyzer tool #128165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea behind this tool was that you'd instrument a source file to measure its debug-info quality, then watch as it progressively got worse with more optimisations being enabled in clang. However we've since stripped the "building" portions of Dexter out as they were ill placed, which makes this tooling redundant. The lack of __init__.py adjacent to it means it couldn't be run anyway. The core idea behind this is still sound; just it's best placed on the other side of the build system, something that Dexter shouldn't try to solve.
SLTozer
approved these changes
Feb 21, 2025
Contributor
SLTozer
left a comment
SLTozer
left a comment
There was a problem hiding this comment.
Thought we'd removed this already! There are no other lingering references to the tool or tests that depend on it AFAICT, so fully removing this file should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this tool was that you'd instrument a source file to measure its debug-info quality, then watch as it progressively got worse with more optimisations being enabled in clang. However we've since stripped the "building" portions of Dexter out as they were ill placed, which makes this tooling redundant. The lack of init.py adjacent to it means it couldn't be run anyway.
The core idea behind this is still sound; just it's best placed on the other side of the build system, something that Dexter shouldn't try to solve.