Skip to content

[AMDGPU] Add verification for amdgcn.init.exec.from.input #128172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 23, 2025
Merged

[AMDGPU] Add verification for amdgcn.init.exec.from.input #128172

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dda8be4
[AMDGPU] Add verification for amdgcn.init.exec.from.input
ro-i Feb 21, 2025
c6f3b88
implement feedback
ro-i Feb 21, 2025
aa34d1e
implement feedback
ro-i Feb 21, 2025
7d2779e
implement feedback
ro-i Feb 21, 2025
f291bc6
implement feedback
ro-i Feb 21, 2025
cdee5fc
Update llvm/test/Verifier/AMDGPU/intrinsic-amdgpu-init-exec-from-inpu…
arsenm Feb 22, 2025
bf2abb6
Update llvm/test/Verifier/AMDGPU/intrinsic-amdgpu-init-exec-from-inpu…
arsenm Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions llvm/lib/IR/Verifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6369,6 +6369,14 @@ void Verifier::visitIntrinsicCall(Intrinsic::ID ID, CallBase &Call) {
"VGPR arguments must not have the `inreg` attribute", &Call);
break;
}
case Intrinsic::amdgcn_init_exec_from_input: {
const Argument *Arg = dyn_cast<Argument>(Call.getOperand(0));
Check(Arg && Arg->hasInRegAttr(),
"only inreg arguments to the parent function are valid as inputs to "
"this intrinsic",
&Call);
break;
}
case Intrinsic::amdgcn_set_inactive_chain_arg: {
auto CallerCC = Call.getCaller()->getCallingConv();
switch (CallerCC) {
Expand Down
27 changes: 27 additions & 0 deletions llvm/test/Verifier/AMDGPU/intrinsic-amdgpu-init-exec-from-input.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
; RUN: not llvm-as -disable-output 2>&1 %s | FileCheck %s

; Function Attrs: convergent nocallback nofree nounwind willreturn
declare void @llvm.amdgcn.init.exec.from.input(i32, i32 immarg) #0
attributes #0 = { convergent nocallback nofree nounwind willreturn }

; CHECK: only inreg arguments to the parent function are valid as inputs to this intrinsic
; CHECK-NEXT: call void @llvm.amdgcn.init.exec.from.input(i32 0, i32 0)
define void @init_exec_from_input_fail_immarg(i32 inreg %a, i32 %b) {
call void @llvm.amdgcn.init.exec.from.input(i32 0, i32 0)
ret void
}

; CHECK: only inreg arguments to the parent function are valid as inputs to this intrinsic
; CHECK-NEXT: call void @llvm.amdgcn.init.exec.from.input(i32 %b, i32 0)
define void @init_exec_from_input_fail_not_inreg(i32 inreg %a, i32 %b) {
call void @llvm.amdgcn.init.exec.from.input(i32 %b, i32 0)
ret void
}
Copy link
Contributor

@arsenm arsenm Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also test a case where it's not an argument (try one with a constant and one with an instruction)

Copy link
Contributor Author

@ro-i ro-i Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I added another check for the case that the operand is an instruction!
Isn't the constant case covered by the first function?


; CHECK: only inreg arguments to the parent function are valid as inputs to this intrinsic
; CHECK-NEXT: call void @llvm.amdgcn.init.exec.from.input(i32 %c, i32 0)
define void @init_exec_from_input_fail_constant(i32 inreg %a, i32 %b) {
%c = add i32 %a, %b
call void @llvm.amdgcn.init.exec.from.input(i32 %c, i32 0)
ret void
}