Skip to content

[libc] Temporarily disable LlvmLibcFileTest.WriteOnly in libc.test.src.__support.File.file_test.__hermetic__ due to precommit bots's consistent failures. #128186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[libc] Temporarily disable LlvmLibcFileTest.WriteOnly in libc.test.src.__support.File.file_test.__hermetic__ due to precommit bots's consistent failures. #128186

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6ce3f46
[libc] Temporarily disable LlvmLibcFileTest.WriteOnly in libc.test.sr…
lntue Feb 21, 2025
6c72474
Apply comment.
lntue Feb 21, 2025
f55e5f6
New file test failure.
lntue Feb 21, 2025
101ba37
Try to set the test hermetic only in full build mode.
lntue Feb 21, 2025
90b1245
Remove x86_64 check because the precommit failed in aarch64.
lntue Feb 21, 2025
8228342
Change to UNIT_TEST_ONLY.
lntue Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 40 additions & 37 deletions libc/test/src/__support/File/file_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,43 +113,46 @@ StringFile *new_string_file(char *buffer, size_t buflen, int bufmode,
LIBC_NAMESPACE::File::mode_flags(mode));
}

TEST(LlvmLibcFileTest, WriteOnly) {
const char data[] = "hello, file";
constexpr size_t FILE_BUFFER_SIZE = sizeof(data) * 3 / 2;
char file_buffer[FILE_BUFFER_SIZE];
StringFile *f =
new_string_file(file_buffer, FILE_BUFFER_SIZE, _IOFBF, false, "w");

ASSERT_EQ(sizeof(data), f->write(data, sizeof(data)).value);
EXPECT_EQ(f->get_pos(), size_t(0)); // Data is buffered in the file stream
ASSERT_EQ(f->flush(), 0);
EXPECT_EQ(f->get_pos(), sizeof(data)); // Data should now be available
EXPECT_STREQ(f->get_str(), data);

f->reset();
ASSERT_EQ(f->get_pos(), size_t(0));
ASSERT_EQ(sizeof(data), f->write(data, sizeof(data)).value);
EXPECT_EQ(f->get_pos(), size_t(0)); // Data is buffered in the file stream
// The second write should trigger a buffer flush.
ASSERT_EQ(sizeof(data), f->write(data, sizeof(data)).value);
EXPECT_GE(f->get_pos(), size_t(0));
ASSERT_EQ(f->flush(), 0);
EXPECT_EQ(f->get_pos(), 2 * sizeof(data));
MemoryView src1("hello, file\0hello, file", sizeof(data) * 2),
dst1(f->get_str(), sizeof(data) * 2);
EXPECT_MEM_EQ(src1, dst1);

char read_data[sizeof(data)];
{
// This is not a readable file.
auto result = f->read(read_data, sizeof(data));
EXPECT_EQ(result.value, size_t(0));
EXPECT_TRUE(f->error());
EXPECT_TRUE(result.has_error());
}

ASSERT_EQ(f->close(), 0);
}
// TODO: Investigate the precommit bots' failures of this test and re-enable it.
Copy link
Contributor

@jhuber6 jhuber6 Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use

#if 0
...
#endif

Copy link
Contributor Author

@lntue lntue Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@petrhosek petrhosek Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google Test supports disabling tests by prefixing their name with DISABLED_. This is better than commenting out the code or using #if 0, as disabled tests are still compiled (and thus won't rot). We should consider implementing the same feature in libc's test framework.

Copy link
Contributor

@jhuber6 jhuber6 Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd probably want that to be target dependent as well, there's a handful of places where I need to disable a test only on NVPTX for example.

// https://github.com/llvm/llvm-project/issues/128185.
//
// TEST(LlvmLibcFileTest, WriteOnly) {
// const char data[] = "hello, file";
// constexpr size_t FILE_BUFFER_SIZE = sizeof(data) * 3 / 2;
// char file_buffer[FILE_BUFFER_SIZE];
// StringFile *f =
// new_string_file(file_buffer, FILE_BUFFER_SIZE, _IOFBF, false, "w");

// ASSERT_EQ(sizeof(data), f->write(data, sizeof(data)).value);
// EXPECT_EQ(f->get_pos(), size_t(0)); // Data is buffered in the file stream
// ASSERT_EQ(f->flush(), 0);
// EXPECT_EQ(f->get_pos(), sizeof(data)); // Data should now be available
// EXPECT_STREQ(f->get_str(), data);

// f->reset();
// ASSERT_EQ(f->get_pos(), size_t(0));
// ASSERT_EQ(sizeof(data), f->write(data, sizeof(data)).value);
// EXPECT_EQ(f->get_pos(), size_t(0)); // Data is buffered in the file stream
// // The second write should trigger a buffer flush.
// ASSERT_EQ(sizeof(data), f->write(data, sizeof(data)).value);
// EXPECT_GE(f->get_pos(), size_t(0));
// ASSERT_EQ(f->flush(), 0);
// EXPECT_EQ(f->get_pos(), 2 * sizeof(data));
// MemoryView src1("hello, file\0hello, file", sizeof(data) * 2),
// dst1(f->get_str(), sizeof(data) * 2);
// EXPECT_MEM_EQ(src1, dst1);

// char read_data[sizeof(data)];
// {
// // This is not a readable file.
// auto result = f->read(read_data, sizeof(data));
// EXPECT_EQ(result.value, size_t(0));
// EXPECT_TRUE(f->error());
// EXPECT_TRUE(result.has_error());
// }

// ASSERT_EQ(f->close(), 0);
// }

TEST(LlvmLibcFileTest, WriteLineBuffered) {
const char data[] = "hello\n file";
Expand Down
Loading