Skip to content

Conversation

@foxtran
Copy link
Member

@foxtran foxtran commented Feb 21, 2025

This PR fixes warning which occurs if one compiles OpenMP runtime with GCC:

warning: comparison of integer expressions of different signedness: 'kmp_intptr_t' {aka 'long int'} and 'long unsigned int' [-Wsign-compare]

@llvmbot llvmbot added the openmp:libomp OpenMP host runtime label Feb 21, 2025
Copy link
Collaborator

@jprotze jprotze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.
The change follows the comparison of the same value in other parts of this file as introduced in 59b877d.

@foxtran
Copy link
Member Author

foxtran commented Mar 2, 2025

@jprotze, could you please merge it?

@jprotze jprotze merged commit 3f48d34 into llvm:main Mar 3, 2025
11 checks passed
@foxtran foxtran deleted the fix/openmp-integer-comparison branch March 3, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

openmp:libomp OpenMP host runtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants