Skip to content

Conversation

@kazutakahirata
Copy link
Contributor

No description provided.

@kazutakahirata kazutakahirata requested a review from nikic February 22, 2025 07:54
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Feb 22, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 22, 2025

@llvm/pr-subscribers-clang

Author: Kazu Hirata (kazutakahirata)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/128297.diff

1 Files Affected:

  • (modified) clang/tools/clang-offload-packager/ClangOffloadPackager.cpp (+3-3)
diff --git a/clang/tools/clang-offload-packager/ClangOffloadPackager.cpp b/clang/tools/clang-offload-packager/ClangOffloadPackager.cpp
index 49cb0d70f492b..8cd9691c30ada 100644
--- a/clang/tools/clang-offload-packager/ClangOffloadPackager.cpp
+++ b/clang/tools/clang-offload-packager/ClangOffloadPackager.cpp
@@ -198,12 +198,12 @@ static Error unbundleImages() {
               Args["file"], Members, SymtabWritingMode::NormalSymtab,
               Archive::getDefaultKind(), true, false, nullptr))
         return E;
-    } else if (Args.count("file")) {
+    } else if (auto It = Args.find("file"); It != Args.end()) {
       if (Extracted.size() > 1)
         WithColor::warning(errs(), PackagerExecutable)
-            << "Multiple inputs match to a single file, '" << Args["file"]
+            << "Multiple inputs match to a single file, '" << It->second
             << "'\n";
-      if (Error E = writeFile(Args["file"], Extracted.back()->getImage()))
+      if (Error E = writeFile(It->second, Extracted.back()->getImage()))
         return E;
     } else {
       uint64_t Idx = 0;

@kazutakahirata kazutakahirata merged commit 8f7e34b into llvm:main Feb 22, 2025
13 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_repeated_hash_lookups_clang_offload branch February 22, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants