Skip to content

[Analysis] Avoid repeated hash lookups (NFC) #128394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2025
Merged

[Analysis] Avoid repeated hash lookups (NFC) #128394

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c725cd1
[Analysis] Avoid repeated hash lookups (NFC)
kazutakahirata Feb 22, 2025
17929cc
Update It->second even when the key-value pair is already present.
kazutakahirata Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions llvm/lib/Analysis/LoopAccessAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1443,12 +1443,11 @@ void AccessAnalysis::processMemAccesses() {
UnderlyingObj->getType()->getPointerAddressSpace()))
continue;

UnderlyingObjToAccessMap::iterator Prev =
ObjToLastAccess.find(UnderlyingObj);
if (Prev != ObjToLastAccess.end())
DepCands.unionSets(Access, Prev->second);
auto [It, Inserted] =
ObjToLastAccess.try_emplace(UnderlyingObj, Access);
if (!Inserted)
DepCands.unionSets(Access, It->second);

ObjToLastAccess[UnderlyingObj] = Access;
LLVM_DEBUG(dbgs() << " " << *UnderlyingObj << "\n");
}
}
Expand Down