Skip to content

Conversation

@charithaintc
Copy link
Contributor

@llvmbot
Copy link
Member

llvmbot commented Feb 24, 2025

@llvm/pr-subscribers-mlir

Author: Charitha Saumya (charithaintc)

Changes

log : https://buildkite.com/llvm-project/upstream-bazel/builds/126651#019539f0-5f18-4e60-a126-2d5222c86b9d


Full diff: https://github.com/llvm/llvm-project/pull/128595.diff

1 Files Affected:

  • (modified) mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp (-1)
diff --git a/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp b/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp
index fc9498a886aa3..534a036b566cf 100644
--- a/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp
+++ b/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp
@@ -13,7 +13,6 @@
 #include "mlir/IR/BuiltinTypes.h"
 #include "mlir/IR/Diagnostics.h"
 #include "mlir/IR/TypeUtilities.h"
-#include "mlir/Support/LLVM.h"
 
 #include "llvm/Support/Debug.h"
 #include "llvm/Support/LogicalResult.h"

@llvmbot
Copy link
Member

llvmbot commented Feb 24, 2025

@llvm/pr-subscribers-mlir-gpu

Author: Charitha Saumya (charithaintc)

Changes

log : https://buildkite.com/llvm-project/upstream-bazel/builds/126651#019539f0-5f18-4e60-a126-2d5222c86b9d


Full diff: https://github.com/llvm/llvm-project/pull/128595.diff

1 Files Affected:

  • (modified) mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp (-1)
diff --git a/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp b/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp
index fc9498a886aa3..534a036b566cf 100644
--- a/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp
+++ b/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp
@@ -13,7 +13,6 @@
 #include "mlir/IR/BuiltinTypes.h"
 #include "mlir/IR/Diagnostics.h"
 #include "mlir/IR/TypeUtilities.h"
-#include "mlir/Support/LLVM.h"
 
 #include "llvm/Support/Debug.h"
 #include "llvm/Support/LogicalResult.h"

@adam-smnk
Copy link
Contributor

Looks fine but I'm not familiar with Bazel builds.
@charithaintc Perhaps double check that no other unnecessary headers are added just to be safe

@charithaintc
Copy link
Contributor Author

Looks fine but I'm not familiar with Bazel builds. @charithaintc Perhaps double check that no other unnecessary headers are added just to be safe

turns out none of the new headers added are really needed. I used vscode with clangd, somehow they were added automatically.

Removed them.

Wondering if there is way to do this cleanly. Is there some kind of a pre-commit hook I can use for this?

@adam-smnk adam-smnk merged commit 60cc3af into llvm:main Feb 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants