Skip to content

[windows] Always pass fp128 arguments indirectly #128848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025
Merged

[windows] Always pass fp128 arguments indirectly #128848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e17464
[windows] Add fp128 ABI tests and Windows libcall tests (NFC)
tgross35 Feb 26, 2025
e0a3738
[windows] Always pass `fp128` arguments indirectly
tgross35 Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions llvm/docs/ReleaseNotes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,9 @@ Changes to the WebAssembly Backend
Changes to the Windows Target
-----------------------------

* `fp128` is now passed indirectly, meaning it uses the same calling convention
as `i128`.

Changes to the X86 Backend
--------------------------

Expand Down
3 changes: 2 additions & 1 deletion llvm/lib/Target/X86/X86CallingConv.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,8 +639,9 @@ def CC_X86_Win64_C : CallingConv<[
// 512 bit vectors are passed by pointer
CCIfType<[v64i8, v32i16, v16i32, v32f16, v32bf16, v16f32, v8f64, v8i64], CCPassIndirect<i64>>,

// Long doubles are passed by pointer
// Float types larger than 64-bits (long double and fp128) are passed by pointer
CCIfType<[f80], CCPassIndirect<i64>>,
CCIfType<[f128], CCPassIndirect<i64>>,

// If SSE was disabled, pass FP values smaller than 64-bits as integers in
// GPRs or on the stack.
Expand Down
Loading
Loading