Skip to content

Conversation

@llvmbot
Copy link
Member

@llvmbot llvmbot commented Feb 26, 2025

Backport a684e0e

Requested by: @tstellar

Since d194c6b this workflow was missing
the secret input which was causing it to fail.

(cherry picked from commit a684e0e)
@llvmbot
Copy link
Member Author

llvmbot commented Feb 26, 2025

@boomanaiden154 What do you think about merging this PR to the release branch?

@llvmbot
Copy link
Member Author

llvmbot commented Feb 26, 2025

@llvm/pr-subscribers-github-workflow

Author: None (llvmbot)

Changes

Backport a684e0e

Requested by: @tstellar


Full diff: https://github.com/llvm/llvm-project/pull/128884.diff

1 Files Affected:

  • (modified) .github/workflows/release-binaries-all.yml (+4)
diff --git a/.github/workflows/release-binaries-all.yml b/.github/workflows/release-binaries-all.yml
index d18b9b0b5c2ff..fd4694ebea32d 100644
--- a/.github/workflows/release-binaries-all.yml
+++ b/.github/workflows/release-binaries-all.yml
@@ -27,6 +27,10 @@ on:
         required: true
         default: false
         type: boolean
+    secrets:
+      RELEASE_TASKS_USER_TOKEN:
+        description: "Secret used to check user permissions."
+        required: false
 
   pull_request:
     types:

@github-project-automation github-project-automation bot moved this from Needs Triage to Needs Merge in LLVM Release Status Feb 26, 2025
@tstellar
Copy link
Collaborator

tstellar commented Mar 1, 2025

Does this need to be in 20.1.0 or could it wait until 20.1.1 ?

@tstellar tstellar merged commit 83058aa into llvm:release/20.x Mar 4, 2025
24 of 28 checks passed
@github-project-automation github-project-automation bot moved this from Needs Merge to Done in LLVM Release Status Mar 4, 2025
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

@tstellar (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants