Skip to content

Conversation

@sschaller
Copy link
Contributor

Fixes #126200.
At the moment, GlobalISel is missing an implementation for emulated TLS variables.
I fixed the issue by falling back to SDAG in this case, as I currently don't have the knowledge to implement it myself.

@github-actions
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@sschaller sschaller changed the base branch from main to release/19.x February 27, 2025 16:11
@nikic
Copy link
Contributor

nikic commented Feb 27, 2025

This needs to go into the main branch first, before it can be considered for backport (to LLVM 20 only).

I'll close this PR due to the mass-subscribe.

@nikic nikic closed this Feb 27, 2025
@sschaller
Copy link
Contributor Author

Will do, sorry about that.

@ldionne ldionne removed request for a team March 19, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Miscompilation: Missing prefixes for emulatedTLS variables on macOS/ARM64 with -O0

3 participants