Skip to content

Conversation

@michaelrj-google
Copy link
Contributor

The downstream build was having trouble transforming the previous list
comprehension, but it works on this one. I guess it just needs to look
like a proper target.

The downstream build was having trouble transforming the previous list
comprehension, but it works on this one. I guess it just needs to look
like a proper target.
@llvmbot llvmbot added libc bazel "Peripheral" support tier build system: utils/bazel labels Feb 27, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 27, 2025

@llvm/pr-subscribers-libc

Author: Michael Jones (michaelrj-google)

Changes

The downstream build was having trouble transforming the previous list
comprehension, but it works on this one. I guess it just needs to look
like a proper target.


Full diff: https://github.com/llvm/llvm-project/pull/129119.diff

1 Files Affected:

  • (modified) utils/bazel/llvm-project-overlay/libc/test/src/stdbit/BUILD.bazel (+4-1)
diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/stdbit/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/stdbit/BUILD.bazel
index e7ddbdf41e517..b9d153947dc7d 100644
--- a/utils/bazel/llvm-project-overlay/libc/test/src/stdbit/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/test/src/stdbit/BUILD.bazel
@@ -39,7 +39,10 @@ bit_prefix_list = [
     libc_test(
         name = bit_prefix + bit_suffix + "_test",
         srcs = [bit_prefix + bit_suffix + "_test.cpp"],
-        libc_function_deps = ["//libc:" + bit_prefix + bit_suffix],
+        libc_function_deps = ["//libc:func_name".replace(
+            "func_name",
+            bit_prefix + bit_suffix,
+        )],
         deps = ["//libc:__support_cpp_limits"],
     )
     for bit_prefix in bit_prefix_list

@michaelrj-google michaelrj-google merged commit 310c377 into llvm:main Feb 27, 2025
10 of 12 checks passed
@michaelrj-google michaelrj-google deleted the libcStdbitBazelFix branch February 27, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bazel "Peripheral" support tier build system: utils/bazel libc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants