Skip to content

[llvm][CodeGen] Fix the empty interval issue in Window Scheduler(#128714) #129204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 17, 2025
Merged

[llvm][CodeGen] Fix the empty interval issue in Window Scheduler(#128714) #129204

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
40c675f
[llvm][CodeGen] Fix the empty interval issue in Window Scheduler(#128…
huaatian Feb 28, 2025
a5a28f9
[llvm][CodeGen] Modifications made based on review comments 1
huaatian Feb 28, 2025
10934db
[llvm][CodeGen] Modifications made based on review comments 2
huaatian Mar 10, 2025
f602aa6
[llvm][CodeGen] Modifications made based on review comments 3
huaatian Mar 10, 2025
c71564e
[llvm][CodeGen] Modifications made based on review comments 4
huaatian Mar 11, 2025
5e252bc
[llvm][CodeGen] Modifications made based on review comments 5
huaatian Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions llvm/lib/CodeGen/ModuloSchedule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,20 +951,8 @@ void ModuloScheduleExpander::addBranches(MachineBasicBlock &PreheaderBB,
/// Some registers are generated during the kernel expansion. We calculate the
/// live intervals of these registers after the expansion.
void ModuloScheduleExpander::calculateIntervals() {
// The interval can be computed if all the register's non-debug users have
// slot indexes.
auto CanCalculateInterval = [this](Register Reg) -> bool {
for (auto &Opnd : this->MRI.reg_nodbg_operands(Reg))
if (this->LIS.isNotInMIMap(*Opnd.getParent()))
return false;
return true;
};
for (auto Reg : NoIntervalRegs) {
if (CanCalculateInterval(Reg))
LIS.createAndComputeVirtRegInterval(Reg);
else
LIS.createEmptyInterval(Reg);
}
for (auto Reg : NoIntervalRegs)
Copy link
Contributor

@arsenm arsenm Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no auto

Copy link
Contributor Author

@huaatian huaatian Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

LIS.createAndComputeVirtRegInterval(Reg);
NoIntervalRegs.clear();
}

Expand Down
Loading