-
Notifications
You must be signed in to change notification settings - Fork 15.4k
[modules] Add missing test file for b21ee08e57173102b67bc18237b135550 #129221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The commit missed a test file.
|
@llvm/pr-subscribers-clang Author: Haojian Wu (hokein) ChangesThe commit missed a test file. Full diff: https://github.com/llvm/llvm-project/pull/129221.diff 1 Files Affected:
diff --git a/clang/test/Modules/pr28744.cpp b/clang/test/Modules/pr28744.cpp
new file mode 100644
index 0000000000000..2089872a2a75a
--- /dev/null
+++ b/clang/test/Modules/pr28744.cpp
@@ -0,0 +1,17 @@
+// RUN: rm -rf %t
+// RUN: %clang_cc1 -std=c++11 -I%S/Inputs/PR28794 -verify %s
+// RUN: %clang_cc1 -std=c++11 -fmodules -fmodule-map-file=%S/Inputs/PR28794/module.modulemap -fmodules-cache-path=%t -I%S/Inputs/PR28794/ -verify %s
+
+#include "Subdir/Empty.h"
+#include "LibAHeader.h"
+
+BumpPtrAllocatorImpl<> &getPreprocessorAllocator();
+class B {
+ struct ModuleMacroInfo {
+ ModuleMacroInfo *getModuleInfo() {
+ return new (getPreprocessorAllocator()) ModuleMacroInfo();
+ }
+ };
+};
+
+// expected-no-diagnostics
|
|
@llvm/pr-subscribers-clang-modules Author: Haojian Wu (hokein) ChangesThe commit missed a test file. Full diff: https://github.com/llvm/llvm-project/pull/129221.diff 1 Files Affected:
diff --git a/clang/test/Modules/pr28744.cpp b/clang/test/Modules/pr28744.cpp
new file mode 100644
index 0000000000000..2089872a2a75a
--- /dev/null
+++ b/clang/test/Modules/pr28744.cpp
@@ -0,0 +1,17 @@
+// RUN: rm -rf %t
+// RUN: %clang_cc1 -std=c++11 -I%S/Inputs/PR28794 -verify %s
+// RUN: %clang_cc1 -std=c++11 -fmodules -fmodule-map-file=%S/Inputs/PR28794/module.modulemap -fmodules-cache-path=%t -I%S/Inputs/PR28794/ -verify %s
+
+#include "Subdir/Empty.h"
+#include "LibAHeader.h"
+
+BumpPtrAllocatorImpl<> &getPreprocessorAllocator();
+class B {
+ struct ModuleMacroInfo {
+ ModuleMacroInfo *getModuleInfo() {
+ return new (getPreprocessorAllocator()) ModuleMacroInfo();
+ }
+ };
+};
+
+// expected-no-diagnostics
|
vgvassilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/94/builds/4812 Here is the relevant piece of the build log for the reference |
The commit missed a test file.
The commit missed a test file.