Skip to content

Remove unneeded global inits #129245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Remove unneeded global inits #129245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d13791b
Remove redundant assert from AsmWriter
jph-13 Feb 24, 2025
2a2431c
Merge branch 'llvm:main' into main
jph-13 Feb 24, 2025
a924776
Merge branch 'main' into main
jph-13 Feb 25, 2025
62f73a7
Merge branch 'main' into main
jph-13 Feb 25, 2025
e512e6a
Merge branch 'main' into main
jph-13 Feb 28, 2025
e74e0e4
Update Const to Avoid Un-needed Global Inits
jph-13 Feb 28, 2025
84e56af
Merge branch 'main' into remove_unneeded_global_inits
jph-13 Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions llvm/include/llvm/TargetParser/ARMTargetParser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,15 @@ struct ExtName {
StringRef NegFeature;
};

const ExtName ARCHExtNames[] = {
constexpr ExtName ARCHExtNames[] = {
#define ARM_ARCH_EXT_NAME(NAME, ID, FEATURE, NEGFEATURE) \
{NAME, ID, FEATURE, NEGFEATURE},
#include "ARMTargetParser.def"
};

// List of HWDiv names (use getHWDivSynonym) and which architectural
// features they correspond to (use getHWDivFeatures).
const struct {
constexpr struct {
StringRef Name;
uint64_t ID;
} HWDivNames[] = {
Expand All @@ -112,7 +112,7 @@ struct CpuNames {
uint64_t DefaultExtensions;
};

const CpuNames CPUNames[] = {
constexpr CpuNames CPUNames[] = {
#define ARM_CPU_NAME(NAME, ID, DEFAULT_FPU, IS_DEFAULT, DEFAULT_EXT) \
{NAME, ARM::ArchKind::ID, IS_DEFAULT, DEFAULT_EXT},
#include "ARMTargetParser.def"
Expand Down Expand Up @@ -173,7 +173,7 @@ struct FPUName {
FPURestriction Restriction;
};

static const FPUName FPUNames[] = {
static constexpr FPUName FPUNames[] = {
#define ARM_FPU(NAME, KIND, VERSION, NEON_SUPPORT, RESTRICTION) \
{NAME, KIND, VERSION, NEON_SUPPORT, RESTRICTION},
#include "llvm/TargetParser/ARMTargetParser.def"
Expand All @@ -199,7 +199,7 @@ struct ArchNames {
StringRef getSubArch() const { return ArchFeature.substr(1); }
};

static const ArchNames ARMArchNames[] = {
static constexpr ArchNames ARMArchNames[] = {
#define ARM_ARCH(NAME, ID, CPU_ATTR, ARCH_FEATURE, ARCH_ATTR, ARCH_FPU, \
ARCH_BASE_EXT) \
{NAME, CPU_ATTR, ARCH_FEATURE, ARCH_FPU, \
Expand Down
1 change: 0 additions & 1 deletion llvm/lib/IR/AsmWriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2117,7 +2117,6 @@ static void writeDIGenericSubrange(raw_ostream &Out, const DIGenericSubrange *N,
};

auto GetConstant = [&](Metadata *Bound) -> int64_t {
assert(IsConstant(Bound) && "Expected constant");
Copy link
Collaborator

@davemgreen davemgreen Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this unrelated to the constexpr?

Copy link
Contributor Author

@jph-13 jph-13 Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Sorry for the confusion. That was supposed to be on a different PR. It was just another thing noticed.

auto *BE = dyn_cast_or_null<DIExpression>(Bound);
return static_cast<int64_t>(BE->getElement(1));
};
Expand Down