Skip to content

[AMDGPU][True16][CodeGen] gisel true16 for G_MERGE #129287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[AMDGPU][True16][CodeGen] gisel true16 for G_MERGE #129287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ bool AMDGPUInstructionSelector::selectG_MERGE_VALUES(MachineInstr &MI) const {
LLT SrcTy = MRI->getType(MI.getOperand(1).getReg());

const unsigned SrcSize = SrcTy.getSizeInBits();
if (SrcSize < 32)
if (SrcSize < 16)
Copy link
Contributor

@arsenm arsenm Mar 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand why this is selectImpl. This is just a fancy way of failing? Is this incorrectly passing selection for non-true16 targets?

Copy link
Contributor Author

@broxigarchen broxigarchen Mar 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked this. It seems this is never invoked when srcSize is smaller than 32.

we might just don't need this patch (test is also not relevant)

return selectImpl(MI, *CoverageInfo);

const DebugLoc &DL = MI.getDebugLoc();
Expand Down
Loading