[libc++][test] XFAIL for FreeBSD in thread_create_failure.pass.cpp #129413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre https://man.freebsd.org/cgi/man.cgi?query=setrlimit, FreeBSD's `setrlimit` seems to limit the number of processes, not threads via `RLIMIT_NPROC`. So this test should be XFAIL for FreeBSD.
frederick-vs-ja
added
libc++
Member
|
@llvm/pr-subscribers-libcxx Author: A. Jiang (frederick-vs-ja) ChangesPre https://man.freebsd.org/cgi/man.cgi?query=setrlimit, FreeBSD's Full diff: https://github.com/llvm/llvm-project/pull/129413.diff 1 Files Affected:
diff --git a/libcxx/test/std/thread/futures/futures.async/thread_create_failure.pass.cpp b/libcxx/test/std/thread/futures/futures.async/thread_create_failure.pass.cpp
index 0d0c63058d656..d4f7cb771781c 100644
--- a/libcxx/test/std/thread/futures/futures.async/thread_create_failure.pass.cpp
+++ b/libcxx/test/std/thread/futures/futures.async/thread_create_failure.pass.cpp
@@ -17,9 +17,10 @@
// There is no way to limit the number of threads on windows
// UNSUPPORTED: windows
-// AIX and macOS seem to limit the number of processes, not threads via RLIMIT_NPROC
+// AIX, FreeBSD, and macOS seem to limit the number of processes, not threads via RLIMIT_NPROC
// XFAIL: target={{.+}}-aix{{.*}}
// XFAIL: target={{.+}}-apple-{{.*}}
+// XFAIL: freebsd
// This test makes sure that we fail gracefully in care the thread creation fails. This is only reliably possible on
// systems that allow limiting the number of threads that can be created. See https://llvm.org/PR125428 for more details
|
philnik777
approved these changes
Mar 2, 2025
Contributor
philnik777
left a comment
philnik777
left a comment
There was a problem hiding this comment.
I wonder whether we should just make this // REQUIRES: target={{.+}}-linux{{.*}}, but this LGTM to get the CI happy again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://man.freebsd.org/cgi/man.cgi?query=setrlimit, FreeBSD's
setrlimitseems to limit the number of processes, not threads viaRLIMIT_NPROC. So this test should be XFAIL for FreeBSD.