Skip to content

[Metadata] Replace undef VAMs with poison VAMs #129450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025
Merged

[Metadata] Replace undef VAMs with poison VAMs #129450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions llvm/lib/IR/Metadata.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,8 @@ void ReplaceableMetadataImpl::SalvageDebugInfo(const Constant &C) {
ValueAsMetadata *MD = I->second;
using UseTy =
std::pair<void *, std::pair<MetadataTracking::OwnerTy, uint64_t>>;
// Copy out uses and update value of Constant used by debug info metadata with undef below
// Copy out uses and update value of Constant used by debug info metadata with
// poison below
SmallVector<UseTy, 8> Uses(MD->UseMap.begin(), MD->UseMap.end());

for (const auto &Pair : Uses) {
Expand All @@ -349,7 +350,7 @@ void ReplaceableMetadataImpl::SalvageDebugInfo(const Constant &C) {
// Check for MetadataAsValue.
if (isa<MetadataAsValue *>(Owner)) {
cast<MetadataAsValue *>(Owner)->handleChangedMetadata(
ValueAsMetadata::get(UndefValue::get(C.getType())));
ValueAsMetadata::get(PoisonValue::get(C.getType())));
continue;
}
if (!isa<Metadata *>(Owner))
Expand All @@ -359,7 +360,7 @@ void ReplaceableMetadataImpl::SalvageDebugInfo(const Constant &C) {
continue;
if (isa<DINode>(OwnerMD)) {
OwnerMD->handleChangedOperand(
Pair.first, ValueAsMetadata::get(UndefValue::get(C.getType())));
Pair.first, ValueAsMetadata::get(PoisonValue::get(C.getType())));
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion llvm/test/DebugInfo/X86/undef-dbg-val.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
; RUN: opt -S -passes=globalopt --experimental-debuginfo-iterators=false <%s | FileCheck %s
; CHECK: #dbg_value(ptr undef,
; CHECK: #dbg_value(ptr poison,
; CHECK-SAME: [[VAR:![0-9]+]],
; CHECK-SAME: !DIExpression()
; CHECK: [[VAR]] = !DILocalVariable(name: "_format"
Expand Down
Loading