Skip to content

[BOLT] Remove BinaryFunction::IsPatched. NFC #129461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025
Merged

[BOLT] Remove BinaryFunction::IsPatched. NFC #129461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions bolt/include/bolt/Core/BinaryFunction.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,9 +343,6 @@ class BinaryFunction {
/// True if the function uses ORC format for stack unwinding.
bool HasORC{false};

/// True if the original entry point was patched.
bool IsPatched{false};

/// True if the function contains explicit or implicit indirect branch to its
/// split fragments, e.g., split jump table, landing pad in split fragment
bool HasIndirectTargetToSplitFragment{false};
Expand Down Expand Up @@ -1376,9 +1373,6 @@ class BinaryFunction {
/// Return true if the function uses ORC format for stack unwinding.
bool hasORC() const { return HasORC; }

/// Return true if the original entry point was patched.
bool isPatched() const { return IsPatched; }

const JumpTable *getJumpTable(const MCInst &Inst) const {
const uint64_t Address = BC.MIB->getJumpTable(Inst);
return getJumpTableContainingAddress(Address);
Expand Down Expand Up @@ -1729,8 +1723,6 @@ class BinaryFunction {
/// Mark function that should not be emitted.
void setIgnored();

void setIsPatched(bool V) { IsPatched = V; }

void setHasIndirectTargetToSplitFragment(bool V) {
HasIndirectTargetToSplitFragment = V;
}
Expand Down
2 changes: 0 additions & 2 deletions bolt/lib/Passes/PatchEntries.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,6 @@ Error PatchEntries::runOnFunctions(BinaryContext &BC) {
assert(!ColdSize && "unexpected cold code");
assert(HotSize <= PatchSize && "max patch size exceeded");
}

Function.setIsPatched(true);
}
return Error::success();
}
Expand Down
Loading