Skip to content

OrcV2: also set COFF flag overrides when custom linking layer is used #129533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

OrcV2: also set COFF flag overrides when custom linking layer is used #129533

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a28bf0a
OrcV2: also set COFF flag overrides when custom linking layer is used
wjakob Mar 3, 2025
8a2fbf2
Merge branch 'main' into fix
wjakob Mar 7, 2025
eecf6af
incorporate feedback
wjakob Mar 10, 2025
10b43e1
Revert "incorporate feedback"
Mar 11, 2025
de3b77e
Merge branch 'main' into fix
fhahn Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions llvm/lib/ExecutionEngine/Orc/LLJIT.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,8 +950,18 @@ Expected<std::unique_ptr<ObjectLayer>>
LLJIT::createObjectLinkingLayer(LLJITBuilderState &S, ExecutionSession &ES) {

// If the config state provided an ObjectLinkingLayer factory then use it.
if (S.CreateObjectLinkingLayer)
return S.CreateObjectLinkingLayer(ES, S.JTMB->getTargetTriple());
if (S.CreateObjectLinkingLayer) {
auto Layer = S.CreateObjectLinkingLayer(ES, S.JTMB->getTargetTriple());
if (Layer && S.JTMB->getTargetTriple().isOSBinFormatCOFF()) {
auto *RTDyldLayer =
dyn_cast_or_null<RTDyldObjectLinkingLayer>(Layer.get().get());
if (RTDyldLayer) {
RTDyldLayer->setOverrideObjectFlagsWithResponsibilityFlags(true);
RTDyldLayer->setAutoClaimResponsibilityForObjectSymbols(true);
}
}
return Layer;
}

// Otherwise default to creating an RTDyldObjectLinkingLayer that constructs
// a new SectionMemoryManager for each object.
Expand Down
Loading