Skip to content

[IPO] Avoid repeated hash lookups (NFC) #129654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kazutakahirata merged 2 commits into from
Mar 4, 2025
Merged

[IPO] Avoid repeated hash lookups (NFC) #129654

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d31c71
[IPO] Avoid repeated hash lookups (NFC)
kazutakahirata Mar 3, 2025
d5bfb25
Address a comment.
kazutakahirata Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions llvm/include/llvm/Transforms/IPO/ProfiledCallGraph.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,13 +150,13 @@ class ProfiledCallGraph {
private:
void addProfiledCall(FunctionId CallerName, FunctionId CalleeName,
uint64_t Weight = 0) {
assert(ProfiledFunctions.count(CallerName));
auto CallerIt = ProfiledFunctions.find(CallerName);
assert(CallerIt != ProfiledFunctions.end());
auto CalleeIt = ProfiledFunctions.find(CalleeName);
if (CalleeIt == ProfiledFunctions.end())
return;
ProfiledCallGraphEdge Edge(ProfiledFunctions[CallerName],
CalleeIt->second, Weight);
auto &Edges = ProfiledFunctions[CallerName]->Edges;
ProfiledCallGraphEdge Edge(CallerIt->second, CalleeIt->second, Weight);
auto &Edges = CallerIt->second->Edges;
auto [EdgeIt, Inserted] = Edges.insert(Edge);
if (!Inserted) {
// Accumulate weight to the existing edge.
Expand Down
Loading