[LLVM-FLANG] [OpenMP] [Taskloop] - Add test case with cancel construct inside taskloop #129862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t inside taskloop Added a test case with cancel construct inside taskloop. Currently taskloop lowering is not supported so below error is issued: "not yet implemented: Taskloop construct" Once the lowering patch is merged, todo error should be issued for cancel construct. "not yet implemented: OpenMPCancelConstruct"
llvmbot
added
flang
Member
|
@llvm/pr-subscribers-flang-fir-hlfir @llvm/pr-subscribers-flang-openmp Author: Kiran Kumar T P (kiranktp) ChangesAdded a test case with cancel construct inside taskloop. Currently taskloop lowering is not supported so below error is issued: "not yet implemented: Taskloop construct" Full diff: https://github.com/llvm/llvm-project/pull/129862.diff 1 Files Affected:
diff --git a/flang/test/Lower/OpenMP/Todo/taskloop-cancel.f90 b/flang/test/Lower/OpenMP/Todo/taskloop-cancel.f90
new file mode 100644
index 0000000000000..5045c621e4d77
--- /dev/null
+++ b/flang/test/Lower/OpenMP/Todo/taskloop-cancel.f90
@@ -0,0 +1,14 @@
+! RUN: %not_todo_cmd bbc -emit-fir -fopenmp -o - %s -fopenmp-version=50 2>&1 | FileCheck %s
+! RUN: %not_todo_cmd %flang_fc1 -emit-fir -fopenmp -o - %s -fopenmp-version=50 2>&1 | FileCheck %s
+
+! CHECK: not yet implemented: Taskloop construct
+subroutine omp_taskloop
+integer :: i
+!$omp parallel
+ !$omp taskloop
+ do i = 1, 10
+ !$omp cancel taskgroup
+ end do
+ !$omp end taskloop
+!$omp end parallel
+end subroutine omp_taskloop
|
kiranktp
requested review from
NimishMishra,
Thirumalai-Shaktivel,
kaviya2510,
kiranchandramohan,
skatrak and
tblah
skatrak
approved these changes
Mar 6, 2025
Contributor
Author
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test case with cancel construct inside taskloop. Currently taskloop lowering is not supported so below error is issued: "not yet implemented: Taskloop construct"
Once the lowering patch is merged, todo error should be issued for cancel construct. "not yet implemented: OpenMPCancelConstruct"