Skip to content

[lldb-dap] Use LLDB_INVALID_LINE_NUMBER & LLDB_INVALID_COLUMN_NUMBER #129948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JDevlieghere merged 1 commit into from
Mar 6, 2025
Merged

[lldb-dap] Use LLDB_INVALID_LINE_NUMBER & LLDB_INVALID_COLUMN_NUMBER #129948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lldb/tools/lldb-dap/Handler/BreakpointLocationsHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,10 @@ void BreakpointLocationsRequestHandler::operator()(
auto *arguments = request.getObject("arguments");
auto *source = arguments->getObject("source");
std::string path = GetString(source, "path").str();
const auto start_line = GetInteger<uint64_t>(arguments, "line").value_or(0);
const auto start_column =
GetInteger<uint64_t>(arguments, "column").value_or(0);
const auto start_line = GetInteger<uint64_t>(arguments, "line")
.value_or(LLDB_INVALID_LINE_NUMBER);
const auto start_column = GetInteger<uint64_t>(arguments, "column")
.value_or(LLDB_INVALID_COLUMN_NUMBER);
const auto end_line =
GetInteger<uint64_t>(arguments, "endLine").value_or(start_line);
const auto end_column = GetInteger<uint64_t>(arguments, "endColumn")
Expand Down
6 changes: 4 additions & 2 deletions lldb/tools/lldb-dap/SourceBreakpoint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,10 @@ namespace lldb_dap {
SourceBreakpoint::SourceBreakpoint(DAP &dap, const llvm::json::Object &obj)
: Breakpoint(dap, obj),
logMessage(std::string(GetString(obj, "logMessage"))),
line(GetInteger<uint64_t>(obj, "line").value_or(0)),
column(GetInteger<uint64_t>(obj, "column").value_or(0)) {}
line(
GetInteger<uint64_t>(obj, "line").value_or(LLDB_INVALID_LINE_NUMBER)),
column(GetInteger<uint64_t>(obj, "column")
.value_or(LLDB_INVALID_COLUMN_NUMBER)) {}

void SourceBreakpoint::SetBreakpoint(const llvm::StringRef source_path) {
lldb::SBFileSpecList module_list;
Expand Down