[Flang] explicitly link the pthread library when building shared flang-rt. #129956
Conversation
| endif () | ||
| if (build_shared) | ||
| add_library("${name_shared}" SHARED ${extra_args} ${ARG_ADDITIONAL_HEADERS} ${ARG_UNPARSED_ARGUMENTS}) | ||
| find_package(Threads REQUIRED) |
There was a problem hiding this comment.
Can you move find_package(Threads REQUIRED) to flang-rt/CMakeLists.txt? That's where all the requirements are being collected.
flang-rt/CMakeLists.txt
Outdated
There was a problem hiding this comment.
Would be great to comment about why pthread is needed/what for, instead of what it is doing.
https://www.jackfranklin.co.uk/blog/code-comments-why-not-how/
There was a problem hiding this comment.
Sure. I will update the comments.
Thanks for the pointer to the blog!
|
@Meinersbur |
DanielCChen
force-pushed
the
daniel_pthread
branch
from
8b8df2e to
707a4cf
Compare
There was a problem hiding this comment.
I expected it to be trivially present on Windows, as part of the Win32 CRT (there is a CMAKE_USE_WIN32_THREADS_INIT results variable).
Aynway, LGTM
2 participants
This patch is to explicitly link the pthread library when building shared flang-rt.
On AIX, for example, it needs to link in
libpthread.aexplicitly in order to resolve the references to thosepthread_*functions ininclude/flang-rt/runtime/lock.h