Skip to content

[RISCV] Remove the TODO for fmaximum/fminimum from the tests. (NFC) #129969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged

[RISCV] Remove the TODO for fmaximum/fminimum from the tests. (NFC) #129969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions llvm/test/CodeGen/RISCV/double-intrinsics.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,23 +818,6 @@ define double @maxnum_f64(double %a, double %b) nounwind {
ret double %1
}

; TODO: FMINNAN and FMAXNAN aren't handled in
; SelectionDAGLegalize::ExpandNode.

; declare double @llvm.minimum.f64(double, double)

; define double @fminimum_f64(double %a, double %b) nounwind {
; %1 = call double @llvm.minimum.f64(double %a, double %b)
; ret double %1
; }

; declare double @llvm.maximum.f64(double, double)

; define double @fmaximum_f64(double %a, double %b) nounwind {
; %1 = call double @llvm.maximum.f64(double %a, double %b)
; ret double %1
; }

declare double @llvm.copysign.f64(double, double)

define double @copysign_f64(double %a, double %b) nounwind {
Expand Down
17 changes: 0 additions & 17 deletions llvm/test/CodeGen/RISCV/float-intrinsics.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,23 +802,6 @@ define float @maxnum_f32(float %a, float %b) nounwind {
ret float %1
}

; TODO: FMINNAN and FMAXNAN aren't handled in
; SelectionDAGLegalize::ExpandNode.

; declare float @llvm.minimum.f32(float, float)

; define float @fminimum_f32(float %a, float %b) nounwind {
; %1 = call float @llvm.minimum.f32(float %a, float %b)
; ret float %1
; }

; declare float @llvm.maximum.f32(float, float)

; define float @fmaximum_f32(float %a, float %b) nounwind {
; %1 = call float @llvm.maximum.f32(float %a, float %b)
; ret float %1
; }

declare float @llvm.copysign.f32(float, float)

define float @copysign_f32(float %a, float %b) nounwind {
Expand Down
17 changes: 0 additions & 17 deletions llvm/test/CodeGen/RISCV/half-intrinsics.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2135,23 +2135,6 @@ define half @maxnum_f16(half %a, half %b) nounwind {
ret half %1
}

; TODO: FMINNAN and FMAXNAN aren't handled in
; SelectionDAGLegalize::ExpandNode.

; declare half @llvm.minimum.f16(half, half)

; define half @fminimum_f16(half %a, half %b) nounwind {
; %1 = call half @llvm.minimum.f16(half %a, half %b)
; ret half %1
; }

; declare half @llvm.maximum.f16(half, half)

; define half @fmaximum_f16(half %a, half %b) nounwind {
; %1 = call half @llvm.maximum.f16(half %a, half %b)
; ret half %1
; }

declare half @llvm.copysign.f16(half, half)

define half @copysign_f16(half %a, half %b) nounwind {
Expand Down