Skip to content

[NFC][c-index-test] factor data len out #129971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2025
Merged

[NFC][c-index-test] factor data len out #129971

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
801d923
[NFC][c-index-test] factor data len out
jsji Mar 6, 2025
b0e77d2
fix
jsji Mar 6, 2025
1a49025
Merge branch 'main' into refactorlen
jsji Mar 6, 2025
b48ada5
fix
jsji Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions clang/tools/c-index-test/c-index-test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3546,21 +3546,19 @@ static CXIdxClientContainer makeClientContainer(CXClientData *client_data,
char *newStr;
CXIdxClientFile file;
unsigned line, column;
size_t len;
size_t datalen;

name = info->name;
if (!name)
name = "<anon-tag>";

clang_indexLoc_getFileLocation(loc, &file, 0, &line, &column, 0);

len = sizeof(IndexDataStringList) + strlen(name) + digitCount(line) +
digitCount(column) + 3;
node = (IndexDataStringList *)malloc(len);
datalen = strlen(name) + digitCount(line) + digitCount(column) + 3;
node = (IndexDataStringList *)malloc(datalen + sizeof(IndexDataStringList));
assert(node);
newStr = node->data;
snprintf(newStr, len - sizeof(IndexDataStringList), "%s:%d:%d", name, line,
column);
snprintf(newStr, datalen, "%s:%d:%d", name, line, column);

/* Remember string so it can be freed later. */
index_data = (IndexData *)client_data;
Expand Down
Loading