Skip to content

ADT: Switch to a raw pointer for DoubleAPFloat::Floats. #129981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pcc merged 2 commits into from
Mar 6, 2025
Merged

ADT: Switch to a raw pointer for DoubleAPFloat::Floats. #129981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d45e388
[𝘀𝗽𝗿] initial version
pcc Mar 6, 2025
74def90
clang-format
pcc Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion llvm/include/llvm/ADT/APFloat.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,7 @@ IEEEFloat frexp(const IEEEFloat &Val, int &Exp, roundingMode RM);
class DoubleAPFloat final {
// Note: this must be the first data member.
const fltSemantics *Semantics;
std::unique_ptr<APFloat[]> Floats;
APFloat *Floats;

opStatus addImpl(const APFloat &a, const APFloat &aa, const APFloat &c,
const APFloat &cc, roundingMode RM);
Expand All @@ -821,6 +821,7 @@ class DoubleAPFloat final {
DoubleAPFloat(const fltSemantics &S, APFloat &&First, APFloat &&Second);
DoubleAPFloat(const DoubleAPFloat &RHS);
DoubleAPFloat(DoubleAPFloat &&RHS);
~DoubleAPFloat();

DoubleAPFloat &operator=(const DoubleAPFloat &RHS);
inline DoubleAPFloat &operator=(DoubleAPFloat &&RHS);
Expand Down Expand Up @@ -1659,6 +1660,8 @@ const APFloat &DoubleAPFloat::getFirst() const { return Floats[0]; }
APFloat &DoubleAPFloat::getSecond() { return Floats[1]; }
const APFloat &DoubleAPFloat::getSecond() const { return Floats[1]; }

inline DoubleAPFloat::~DoubleAPFloat() { delete[] Floats; }

} // namespace detail

} // namespace llvm
Expand Down
3 changes: 2 additions & 1 deletion llvm/lib/Support/APFloat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4876,8 +4876,9 @@ DoubleAPFloat::DoubleAPFloat(const DoubleAPFloat &RHS)
}

DoubleAPFloat::DoubleAPFloat(DoubleAPFloat &&RHS)
: Semantics(RHS.Semantics), Floats(std::move(RHS.Floats)) {
: Semantics(RHS.Semantics), Floats(RHS.Floats) {
RHS.Semantics = &semBogus;
RHS.Floats = nullptr;
assert(Semantics == &semPPCDoubleDouble);
}

Expand Down
Loading