Skip to content

[Instrumentation] Avoid repeated hash lookups (NFC) #129988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2025
Merged

[Instrumentation] Avoid repeated hash lookups (NFC) #129988

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e61c1a4
[Instrumentation] Avoid repeated hash lookups (NFC)
kazutakahirata Mar 5, 2025
1496bc6
Update llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
kazutakahirata Mar 6, 2025
21470a9
Update llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
kazutakahirata Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1517,9 +1517,10 @@ void PGOUseFunc::populateCoverage(IndexedInstrProfReader *PGOReader) {
CoveredBlocksToProcess.pop();
for (auto *BB : InverseDependencies[CoveredBlock]) {
// If CoveredBlock is covered then BB is covered.
if (Coverage[BB])
bool &Cov = Coverage[BB];
if (Cov)
continue;
Coverage[BB] = true;
Cov = true;
CoveredBlocksToProcess.push(BB);
}
}
Expand Down Expand Up @@ -1563,14 +1564,15 @@ void PGOUseFunc::populateCoverage(IndexedInstrProfReader *PGOReader) {
// successors, e.g., when a block calls a function that may call exit(). In
// those cases, BFI could find its successor to be covered while BCI could
// find its successor to be dead.
if (Coverage[&BB] == IsBlockDead(BB).value_or(false)) {
const bool &Cov = Coverage[&BB];
if (Cov == IsBlockDead(BB).value_or(false)) {
LLVM_DEBUG(
dbgs() << "Found inconsistent block covearge for " << BB.getName()
<< ": BCI=" << (Coverage[&BB] ? "Covered" : "Dead") << " BFI="
<< ": BCI=" << (Cov ? "Covered" : "Dead") << " BFI="
<< (IsBlockDead(BB).value() ? "Dead" : "Covered") << "\n");
++NumCorruptCoverage;
}
if (Coverage[&BB])
if (Cov)
++NumCoveredBlocks;
}
if (PGOVerifyBFI && NumCorruptCoverage) {
Expand Down