Skip to content

[llvm-dwarfdump] Avoid repeated hash lookups (NFC) #129991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
+6 −4
Merged

[llvm-dwarfdump] Avoid repeated hash lookups (NFC) #129991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions llvm/tools/llvm-dwarfdump/Statistics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,8 +529,9 @@ static void collectStatsRecursive(
auto OffsetFn = Die.find(dwarf::DW_AT_abstract_origin);
if (OffsetFn) {
uint64_t OffsetOfInlineFnCopy = (*OffsetFn).getRawUValue();
if (LocalAbstractOriginFnInfo.count(OffsetOfInlineFnCopy)) {
AbstractOriginVars = LocalAbstractOriginFnInfo[OffsetOfInlineFnCopy];
if (auto It = LocalAbstractOriginFnInfo.find(OffsetOfInlineFnCopy);
It != LocalAbstractOriginFnInfo.end()) {
AbstractOriginVars = It->second;
AbstractOriginVarsPtr = &AbstractOriginVars;
} else {
// This means that the DW_AT_inline fn copy is out of order
Expand Down Expand Up @@ -782,9 +783,10 @@ static void collectZeroLocCovForVarsWithAbstractOrigin(
// If there is no entry within LocalAbstractOriginFnInfo for the given
// FnCopyRawUValue, function isn't out-of-order in DWARF. Rather, we have
// CrossCU referencing.
if (!LocalAbstractOriginFnInfo.count(FnCopyRawUValue))
auto It = LocalAbstractOriginFnInfo.find(FnCopyRawUValue);
if (It == LocalAbstractOriginFnInfo.end())
continue;
AbstractOriginVars = LocalAbstractOriginFnInfo[FnCopyRawUValue];
AbstractOriginVars = It->second;
updateVarsWithAbstractOriginLocCovInfo(FnDieWithAbstractOrigin,
AbstractOriginVars);

Expand Down