Skip to content

[EquivClasses] Fix signature of copy-assignment operator #130140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2025
Merged

[EquivClasses] Fix signature of copy-assignment operator #130140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64a286f
[EquivClasses] Fix signature of operator= (NFC)
artagnon Mar 6, 2025
700a266
[EquivClasses] Add unit-test
artagnon Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/include/llvm/ADT/EquivalenceClasses.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ class EquivalenceClasses {
operator=(RHS);
}

const EquivalenceClasses &operator=(const EquivalenceClasses &RHS) {
EquivalenceClasses &operator=(const EquivalenceClasses &RHS) {
TheMapping.clear();
for (iterator I = RHS.begin(), E = RHS.end(); I != E; ++I)
if (I->isLeader()) {
Expand Down
9 changes: 9 additions & 0 deletions llvm/unittests/ADT/EquivalenceClassesTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,15 @@ using namespace llvm;

namespace llvm {

TEST(EquivalenceClassesTest, CopyAssignemnt) {
EquivalenceClasses<int> EC, Copy;
EC.insert(1);
EC.insert(4);
EquivalenceClasses<int> &Ref = Copy = EC;
EXPECT_EQ(Copy.getNumClasses(), 2u);
EXPECT_EQ(&Ref, &Copy);
}

TEST(EquivalenceClassesTest, NoMerges) {
EquivalenceClasses<int> EqClasses;
// Until we merged any sets, check that every element is only equivalent to
Expand Down
Loading