clang/HIP: Use regex for final path separator in hip-partial-link.hip #130291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow this passed the precheck test on the windows bot, but is failing in precheck of unrelated PRs
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang-driver Author: Matt Arsenault (arsenm) ChangesSomehow this passed the precheck test on the windows bot, but is Full diff: https://github.com/llvm/llvm-project/pull/130291.diff 1 Files Affected:
diff --git a/clang/test/Driver/hip-partial-link.hip b/clang/test/Driver/hip-partial-link.hip
index 5580e56978019..5c538556a5070 100644
--- a/clang/test/Driver/hip-partial-link.hip
+++ b/clang/test/Driver/hip-partial-link.hip
@@ -62,11 +62,11 @@
// STATIC: Found undefined HIP fatbin symbol: __hip_fatbin_[[ID2:[0-9a-f]+]]
// STATIC: Found undefined HIP gpubin handle symbol: __hip_gpubin_handle_[[ID1]]
// STATIC: Found undefined HIP gpubin handle symbol: __hip_gpubin_handle_[[ID2]]
-// STATIC: "{{.*}}/clang-offload-bundler" {{.*}}-unbundle
-// STATIC: "{{.*}}/lld" -flavor gnu -m elf64_amdgpu
-// STATIC: "{{.*}}/clang-offload-bundler"
-// STATIC: "{{.*}}/clang{{.*}}" -target x86_64-unknown-linux-gnu
-// STATIC: "{{.*}}/llvm-ar"
+// STATIC: "{{.*[/\\]}}clang-offload-bundler" {{.*}}-unbundle
+// STATIC: "{{.*[/\\]}}lld" -flavor gnu -m elf64_amdgpu
+// STATIC: "{{.*[/\\]}}clang-offload-bundler"
+// STATIC: "{{.*[/\\]}}clang{{.*}}" -target x86_64-unknown-linux-gnu
+// STATIC: "{{.*[/\\]}}llvm-ar"
// RUN: %clang -v --target=x86_64-unknown-linux-gnu --no-offload-new-driver \
// RUN: --hip-link -no-hip-rt -fgpu-rdc --offload-arch=gfx906 \
|
Member
|
@llvm/pr-subscribers-clang Author: Matt Arsenault (arsenm) ChangesSomehow this passed the precheck test on the windows bot, but is Full diff: https://github.com/llvm/llvm-project/pull/130291.diff 1 Files Affected:
diff --git a/clang/test/Driver/hip-partial-link.hip b/clang/test/Driver/hip-partial-link.hip
index 5580e56978019..5c538556a5070 100644
--- a/clang/test/Driver/hip-partial-link.hip
+++ b/clang/test/Driver/hip-partial-link.hip
@@ -62,11 +62,11 @@
// STATIC: Found undefined HIP fatbin symbol: __hip_fatbin_[[ID2:[0-9a-f]+]]
// STATIC: Found undefined HIP gpubin handle symbol: __hip_gpubin_handle_[[ID1]]
// STATIC: Found undefined HIP gpubin handle symbol: __hip_gpubin_handle_[[ID2]]
-// STATIC: "{{.*}}/clang-offload-bundler" {{.*}}-unbundle
-// STATIC: "{{.*}}/lld" -flavor gnu -m elf64_amdgpu
-// STATIC: "{{.*}}/clang-offload-bundler"
-// STATIC: "{{.*}}/clang{{.*}}" -target x86_64-unknown-linux-gnu
-// STATIC: "{{.*}}/llvm-ar"
+// STATIC: "{{.*[/\\]}}clang-offload-bundler" {{.*}}-unbundle
+// STATIC: "{{.*[/\\]}}lld" -flavor gnu -m elf64_amdgpu
+// STATIC: "{{.*[/\\]}}clang-offload-bundler"
+// STATIC: "{{.*[/\\]}}clang{{.*}}" -target x86_64-unknown-linux-gnu
+// STATIC: "{{.*[/\\]}}llvm-ar"
// RUN: %clang -v --target=x86_64-unknown-linux-gnu --no-offload-new-driver \
// RUN: --hip-link -no-hip-rt -fgpu-rdc --offload-arch=gfx906 \
|
jhuber6
reviewed
Mar 7, 2025
Comment on lines
+65
to
+69
| // STATIC: "{{.*[/\\]}}clang-offload-bundler" {{.*}}-unbundle | ||
| // STATIC: "{{.*[/\\]}}lld" -flavor gnu -m elf64_amdgpu | ||
| // STATIC: "{{.*[/\\]}}clang-offload-bundler" | ||
| // STATIC: "{{.*[/\\]}}clang{{.*}}" -target x86_64-unknown-linux-gnu | ||
| // STATIC: "{{.*[/\\]}}llvm-ar" |
Contributor
There was a problem hiding this comment.
I'd recommend checking {{.*}} before the last " in case there's .exe.
Contributor
Author
There was a problem hiding this comment.
I see no exe in the log (maybe something needs to be fixed to add one)? This passed so I guess leave this for another round
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow this passed the precheck test on the windows bot, but is
failing in precheck of unrelated PRs