[MachinePipeliner] Fix use-after-free coping values of the same DenseMap #130311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
vitalybuka
added
the
skip-precommit-approval
Created using spr 1.3.4
topperc
reviewed
Mar 7, 2025
topperc
reviewed
Mar 7, 2025
vitalybuka
deleted the
users/vitalybuka/spr/machinepipeliner-fix-use-after-free-coping-values-of-the-same-densemap
branch
Collaborator
|
This looks like it was always a use-after-free risk. Any idea why my patch exposed it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #130165.
In the code:
VRMap[CurStageNum][Def] = VRMap[CurStageNum][LoopVal]VRMap[CurStageNum][LoopVal]calculates a reference beforeVRMap[CurStageNum][Def]which may rehash the DenseMap.Then the reference can be dead.