Skip to content

[MachinePipeliner] Fix use-after-free coping values of the same DenseMap #130311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 7, 2025
Merged

[MachinePipeliner] Fix use-after-free coping values of the same DenseMap #130311

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a24376
[𝘀𝗽𝗿] initial version
vitalybuka Mar 7, 2025
b6b7f43
less copying
vitalybuka Mar 7, 2025
b9a662d
undo
vitalybuka Mar 7, 2025
fd22351
llvm::
vitalybuka Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions llvm/lib/CodeGen/ModuloSchedule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,8 +410,11 @@ void ModuloScheduleExpander::generateExistingPhis(
Register NewReg = VRMap[PrevStage][LoopVal];
rewriteScheduledInstr(NewBB, InstrMap, CurStageNum, 0, &*BBI, Def,
InitVal, NewReg);
if (VRMap[CurStageNum].count(LoopVal))
VRMap[CurStageNum][Def] = VRMap[CurStageNum][LoopVal];
auto It = VRMap[CurStageNum].find(LoopVal);
if (It != VRMap[CurStageNum].end()) {
Register Reg = It->second;
VRMap[CurStageNum][Def] = Reg;
}
}
// Adjust the number of Phis needed depending on the number of prologs left,
// and the distance from where the Phi is first scheduled. The number of
Expand Down
Loading