Skip to content

Conversation

@artagnon
Copy link
Contributor

@artagnon artagnon commented Mar 7, 2025

It is causing test failures. See https://lab.llvm.org/buildbot/#/builders/65/builds/13399.

-- 8< --
There seems to be no end to issues. I think this is a reasonable compromise. Kindly merge on my behalf, or put up an alternate PR fixing the issue, and merge that: it's bed time for me.

@artagnon artagnon requested review from fhahn and kuhar March 7, 2025 21:33
@llvmbot
Copy link
Member

llvmbot commented Mar 7, 2025

@llvm/pr-subscribers-llvm-adt

Author: Ramkumar Ramachandra (artagnon)

Changes

It is causing test failures. See https://lab.llvm.org/buildbot/#/builders/65/builds/13399.

-- 8< --
There seems to be no end to issues. I think this is a reasonable compromise.


Full diff: https://github.com/llvm/llvm-project/pull/130350.diff

1 Files Affected:

  • (modified) llvm/unittests/ADT/EquivalenceClassesTest.cpp (-1)
diff --git a/llvm/unittests/ADT/EquivalenceClassesTest.cpp b/llvm/unittests/ADT/EquivalenceClassesTest.cpp
index c24c09d8a2815..27918ce01184f 100644
--- a/llvm/unittests/ADT/EquivalenceClassesTest.cpp
+++ b/llvm/unittests/ADT/EquivalenceClassesTest.cpp
@@ -77,7 +77,6 @@ TEST(EquivalenceClassesTest, MembersIterator) {
 
   EquivalenceClasses<int>::iterator I = EC.findValue(EC.getLeaderValue(1));
   EXPECT_THAT(EC.members(I), testing::ElementsAre(5, 1, 2));
-  EXPECT_EQ(EC.members(EC.end()).begin(), EC.member_end());
 }
 
 // Type-parameterized tests: Run the same test cases with different element

Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this caught a genuine issue. Can you either fix forward in near future or file an issue?

@artagnon artagnon closed this Mar 8, 2025
@artagnon artagnon deleted the equivclass-members-it-fix branch March 8, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants