Skip to content

Conversation

@kazutakahirata
Copy link
Contributor

No description provided.

@kazutakahirata kazutakahirata requested a review from nikic March 9, 2025 04:13
@llvmbot llvmbot added the PGO Profile Guided Optimizations label Mar 9, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 9, 2025

@llvm/pr-subscribers-pgo

Author: Kazu Hirata (kazutakahirata)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/130466.diff

1 Files Affected:

  • (modified) llvm/tools/llvm-profgen/MissingFrameInferrer.cpp (+3-3)
diff --git a/llvm/tools/llvm-profgen/MissingFrameInferrer.cpp b/llvm/tools/llvm-profgen/MissingFrameInferrer.cpp
index ac88fced9159c..edfe8979c7121 100644
--- a/llvm/tools/llvm-profgen/MissingFrameInferrer.cpp
+++ b/llvm/tools/llvm-profgen/MissingFrameInferrer.cpp
@@ -165,14 +165,14 @@ uint64_t MissingFrameInferrer::computeUniqueTailCallPath(
   if (CurSearchingDepth == MaximumSearchDepth)
     return 0;
 
-
-  if (!FuncToTailCallMap.count(From))
+  auto It = FuncToTailCallMap.find(From);
+  if (It == FuncToTailCallMap.end())
     return 0;
 
   CurSearchingDepth++;
   Visiting.insert(From);
   uint64_t NumPaths = 0;
-  for (auto TailCall : FuncToTailCallMap[From]) {
+  for (auto TailCall : It->second) {
     NumPaths += computeUniqueTailCallPath(TailCall, To, Path);
     // Stop analyzing the remaining if we are already seeing more than one
     // reachable paths.

@kazutakahirata kazutakahirata merged commit 99d2b3b into llvm:main Mar 9, 2025
13 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_repeated_hash_lookups_llvm_profgen branch March 9, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PGO Profile Guided Optimizations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants