Skip to content

[IPO] Avoid repeated hash lookups (NFC) #130708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2025
Merged

[IPO] Avoid repeated hash lookups (NFC) #130708

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fe6677
[Transforms] Avoid repeated hash lookups (NFC)
kazutakahirata Mar 10, 2025
01a61c8
Address a comment.
kazutakahirata Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions llvm/lib/Transforms/IPO/SampleProfileProbe.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,8 @@ void PseudoProbeVerifier::verifyProbeFactors(
auto &PrevProbeFactors = FunctionProbeFactors[F->getName()];
for (const auto &I : ProbeFactors) {
float CurProbeFactor = I.second;
if (PrevProbeFactors.count(I.first)) {
auto [It, Inserted] = PrevProbeFactors.try_emplace(I.first);
if (!Inserted) {
float PrevProbeFactor = PrevProbeFactors[I.first];
if (std::abs(CurProbeFactor - PrevProbeFactor) >
DistributionFactorVariance) {
Expand All @@ -163,7 +164,7 @@ void PseudoProbeVerifier::verifyProbeFactors(
}

// Update
PrevProbeFactors[I.first] = I.second;
It->second = I.second;
}
}

Expand Down