Skip to content

[BOLT] Improve profile quality reporting #130810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 22, 2025
Merged

[BOLT] Improve profile quality reporting #130810

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
39112ae
Report 0.00% profile quality gaps under empty eligible functions / bl…
ShatianWang Mar 11, 2025
8121b86
Fixed format; added EH stats; skipped selected blocks in CFG flow
ShatianWang Mar 19, 2025
504c78e
clang-format
ShatianWang Apr 3, 2025
707a465
Merge branch 'main' into ModifyFormat
ShatianWang Apr 3, 2025
ae84c47
fix issue with call graph flow conservation score
ShatianWang Apr 3, 2025
fae410b
clang-format
ShatianWang Apr 3, 2025
dd35926
Address comments
ShatianWang Apr 17, 2025
31ce06c
simplify
ShatianWang Apr 18, 2025
0bbd659
clang-format
ShatianWang Apr 18, 2025
2de14fb
fix is invoke check
ShatianWang Apr 22, 2025
9ccb2d7
fix division by zero
ShatianWang Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions bolt/lib/Passes/ProfileQualityStats.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,10 @@ void printCFGContinuityStats(raw_ostream &OS,
FractionECUnreachables.push_back(FractionECUnreachable);
}

if (FractionECUnreachables.empty())
if (FractionECUnreachables.empty()) {
OS << "function CFG discontinuity 0.00%; ";
Copy link
Contributor

@aaupov aaupov Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is due to single-BB functions, right? Can we just assume the discontinuity is 0 for them, instead of skipping in L94-95? And apply a similar logic to other metrics.

return;
}

llvm::sort(FractionECUnreachables);
const int Rank = int(FractionECUnreachables.size() *
Expand Down Expand Up @@ -251,8 +253,10 @@ void printCallGraphFlowConservationStats(
}
}

if (CallGraphGaps.empty())
if (CallGraphGaps.empty()) {
OS << "call graph flow conservation gap 0.00%; ";
return;
}

llvm::sort(CallGraphGaps);
const int Rank =
Expand Down Expand Up @@ -340,8 +344,11 @@ void printCFGFlowConservationStats(raw_ostream &OS,
}
}

if (CFGGapsWeightedAvg.empty())
if (CFGGapsWeightedAvg.empty()) {
OS << "CFG flow conservation gap 0.00% (weighted) 0.00% (worst)\n";
return;
}

llvm::sort(CFGGapsWeightedAvg);
const int RankWA = int(CFGGapsWeightedAvg.size() *
opts::PercentileForProfileQualityCheck / 100);
Expand Down
35 changes: 35 additions & 0 deletions bolt/test/X86/profile-quality-reporting-small-binary.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
## Test that BOLT-INFO is correctly formatted after profile quality reporting for
## a small binary.

# RUN: llvm-mc --filetype=obj --triple x86_64-unknown-unknown %s -o %t.o
# RUN: link_fdata %s %t.o %t.fdata
# RUN: llvm-strip --strip-unneeded %t.o
# RUN: %clang %cflags %t.o -o %t.exe -Wl,-q
# RUN: llvm-bolt %t.exe -o %t.bolt --data=%t.fdata \
# RUN: 2>&1 | FileCheck %s

# CHECK: BOLT-INFO: profile quality metrics for the hottest 2 functions (reporting top 5% values): function CFG discontinuity 0.00%; call graph flow conservation gap 0.00%; CFG flow conservation gap 0.00% (weighted) 0.00% (worst)
# CHECK-NEXT: BOLT-INFO:

.text
.globl func
.type func, @function
func:
pushq %rbp
ret
LLfunc_end:
.size func, LLfunc_end-func


.globl main
.type main, @function
main:
pushq %rbp
movq %rsp, %rbp
LLmain_func:
call func
# FDATA: 1 main #LLmain_func# 1 func 0 0 500
movl $4, %edi
retq
.Lmain_end:
.size main, .Lmain_end-main